Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Sanitize filename before using it as docker image tag. Fix #1069 #1127

Merged
merged 8 commits into from
Jan 13, 2024
Merged

[Core] Sanitize filename before using it as docker image tag. Fix #1069 #1127

merged 8 commits into from
Jan 13, 2024

Conversation

ekzhu
Copy link
Collaborator

@ekzhu ekzhu commented Jan 3, 2024 •
edited
Loading

Why are these changes needed?

Sanitize filename before using it as docker image tag.

In addition, removing the skips for Mac OS X platforms -- they all passed.

Related issue number

Fix #1069

Checks

@ekzhu ekzhu requested a review from sonichi January 3, 2024 04:08
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2024 •
edited
Loading

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (2589ae8) 31.43% compared to head (9d9df99) 41.29%.

Files Patch % Lines
autogen/code_utils.py 25.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1127      +/-   ##
==========================================
+ Coverage   31.43%   41.29%   +9.86%     
==========================================
  Files          32       32              
  Lines        4381     4388       +7     
  Branches     1022     1079      +57     
==========================================
+ Hits         1377     1812     +435     
+ Misses       2896     2436     -460     
- Partials      108      140      +32
Flag Coverage Δ
unittests 41.22% <25.00%> (+9.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekzhu ekzhu marked this pull request as ready for review January 3, 2024 04:48
@ekzhu ekzhu mentioned this pull request Jan 13, 2024
Closed
@ekzhu ekzhu added this pull request to the merge queue Jan 13, 2024
Merged via the queue into main with commit f82248d Jan 13, 2024
78 of 87 checks passed
@sonichi sonichi deleted the fast-dev branch January 13, 2024 18:54
joshkyh pushed a commit that referenced this pull request Jan 17, 2024
@ekzhu @sonichi @joshkyh
[Core] Sanitize filename before using it as docker image tag. Fix #1069…
2dd11e9 
… (#1127)

* fix #1069

* uncomment skips

* use importlib to check package

* better code

---------

Co-authored-by: Chi Wang <wang.chi@microsoft.com>
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
@ekzhu @sonichi
[Core] Sanitize filename before using it as docker image tag. Fix mic…
de0ff6e 
…rosoft#1069 (microsoft#1127)

* fix microsoft#1069

* uncomment skips

* use importlib to check package

* better code

---------

Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afourney afourney afourney left review comments

@sonichi sonichi sonichi left review comments

@BeibinLi BeibinLi BeibinLi approved these changes

Assignees
No one assigned
Labels
code-execution execute generated code docker Issues relating to Docker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: filename containing invalid characters to be used as docker image name
5 participants
@ekzhu @codecov-commenter @afourney @sonichi @BeibinLi