Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[.Net][Bug]: GroupChatExtension.SendAsync doesn't terminate chat when IOrchestrator return null as next agent #3306

Closed
LittleLittleCloud opened this issue Aug 6, 2024 · 0 comments · Fixed by #3310
Closed

[.Net][Bug]: GroupChatExtension.SendAsync doesn't terminate chat when IOrchestrator return null as next agent #3306

LittleLittleCloud opened this issue Aug 6, 2024 · 0 comments · Fixed by #3310
Assignees
@LittleLittleCloud
Labels
dotnet issues related to AutoGen.Net
Milestone
AutoGen.Net 0.1.0

Comments

@LittleLittleCloud
Copy link
Collaborator

LittleLittleCloud commented Aug 6, 2024 •
edited
Loading

Describe the bug

When IOrchestrator returns null as next speaker, GroupChatExtension.SendAsync still continues until the max_round reach
@LittleLittleCloud LittleLittleCloud added bug dotnet issues related to AutoGen.Net labels Aug 6, 2024
@LittleLittleCloud LittleLittleCloud added this to the AutoGen.Net 0.1.0 milestone Aug 6, 2024
@LittleLittleCloud LittleLittleCloud self-assigned this Aug 6, 2024
@LittleLittleCloud LittleLittleCloud mentioned this issue Aug 6, 2024
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Aug 6, 2024
@LittleLittleCloud
[.Net] Fix #3306 (#3310)
cf2fe4a 
* break conversation when orchestartor return null

* enable test on different OS
victordibia pushed a commit that referenced this issue Aug 28, 2024
@LittleLittleCloud @victordibia
[.Net] Fix #3306 (#3310)
b5d410e 
* break conversation when orchestartor return null

* enable test on different OS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LittleLittleCloud LittleLittleCloud

Labels
dotnet issues related to AutoGen.Net
Projects
None yet
Milestone
AutoGen.Net 0.1.0
Development

Successfully merging a pull request may close this issue.

[.Net] Fix #3306 microsoft/autogen
1 participant
@LittleLittleCloud