Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[.Net] Fix #3306 #3310

Merged
merged 2 commits into from
Aug 6, 2024
Merged

[.Net] Fix #3306 #3310

merged 2 commits into from
Aug 6, 2024

Conversation

LittleLittleCloud
Copy link
Collaborator

Why are these changes needed?

Break conversation when no next speaker is selected.

This PR also enables tests on linux and macos os in dotnet-build ci.

Related issue number

Fix #3306

Checks

@sonichi sonichi enabled auto-merge August 6, 2024 21:07
auto-merge was automatically disabled August 6, 2024 21:52

Pull request was closed

@LittleLittleCloud LittleLittleCloud added this pull request to the merge queue Aug 6, 2024
Merged via the queue into main with commit cf2fe4a Aug 6, 2024
68 checks passed
@LittleLittleCloud LittleLittleCloud deleted the u/fix#3306 branch August 6, 2024 22:13
victordibia pushed a commit that referenced this pull request Aug 28, 2024
* break conversation when orchestartor return null

* enable test on different OS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[.Net][Bug]: GroupChatExtension.SendAsync doesn't terminate chat when IOrchestrator return null as next agent
2 participants