Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite and consolidate configuration docs #1581

Merged
merged 28 commits into from
Feb 11, 2024

Conversation

jackgerrits
Copy link
Member

@jackgerrits jackgerrits commented Feb 7, 2024

Why are these changes needed?

I believe the documentation surrounding configuration was confusing, so I had a go at consolidating and hopefully making things clearer.

If you want to view the rendered docs in PDF format (printed by browser) then you can view the below:

LLM Configuration _ AutoGen.pdf

Additionally this adds support for redirects which I think is important to prevent broken links as we continue to work on the documentation.

Related issue number

Closes #797

Checks

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e83de5d) 37.70% compared to head (7d363e4) 37.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1581   +/-   ##
=======================================
  Coverage   37.70%   37.70%           
=======================================
  Files          50       50           
  Lines        5683     5683           
  Branches     1289     1289           
=======================================
  Hits         2143     2143           
  Misses       3372     3372           
  Partials      168      168           
Flag Coverage Δ
unittests 37.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonichi sonichi requested review from qingyun-wu and a team February 8, 2024 18:24
Copy link
Collaborator

@victordibia victordibia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Co-authored-by: gagb <gagb@users.noreply.github.com>
website/docs/llm_configuration.ipynb Outdated Show resolved Hide resolved
Copy link
Collaborator

@AaronWard AaronWard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! thanks for taking my suggestion on board 👍 happy to approve

@sonichi sonichi added this pull request to the merge queue Feb 11, 2024
Merged via the queue into microsoft:main with commit b4a2c6e Feb 11, 2024
19 of 23 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* Rewrite and consolidate configuration docs

* add link to filtering

* updates based on comments

* update lockfile

* update redirect

* spelling mistake

* update the noqa

* update links

* fix broken links

* lint fixes

* address comments

* update wording about model selection

* update cache_seed and json pattern

* add periods

* Update the config json func and other small changes

* update wording of json string

* update intro

* update description of caching

* fix link

* spelling mistake

* fix llm config

* Update website/docs/llm_configuration.ipynb

Co-authored-by: gagb <gagb@users.noreply.github.com>

* Add examples back as notebook

---------

Co-authored-by: gagb <gagb@users.noreply.github.com>
Co-authored-by: Aaron <aaronlaptop12@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

llm_config instructions
6 participants