Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Enhancements in agentchat #1729

Closed
wants to merge 31 commits into from

Conversation

WaelKarkoub
Copy link
Contributor

@WaelKarkoub WaelKarkoub commented Feb 19, 2024

Why are these changes needed?

I noticed some inconsistencies in the formatting of the files, error handling, and type hints. I've only cleaned up the mistakes that I found were "obvious."

Related issue number

Checks

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2024

Codecov Report

Attention: Patch coverage is 86.48649% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 47.02%. Comparing base (d711bd8) to head (0ecbd69).

Files Patch % Lines
autogen/agentchat/conversable_agent.py 60.00% 2 Missing and 2 partials ⚠️
autogen/agentchat/groupchat.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1729       +/-   ##
===========================================
+ Coverage   36.10%   47.02%   +10.92%     
===========================================
  Files          63       63               
  Lines        6658     6681       +23     
  Branches     1470     1599      +129     
===========================================
+ Hits         2404     3142      +738     
+ Misses       4056     3284      -772     
- Partials      198      255       +57     
Flag Coverage Δ
unittests 46.95% <86.48%> (+10.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekzhu
Copy link
Collaborator

ekzhu commented Mar 6, 2024

@sonichi @qingyun-wu this change requires open ai tests.

@sonichi
Copy link
Contributor

sonichi commented Mar 7, 2024

@sonichi @qingyun-wu this change requires open ai tests.

Then it needs to be made from the main repo. @WaelKarkoub could you create a branch in the main repo and then make a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants