-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General Enhancements in agentchat #1729
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1729 +/- ##
===========================================
+ Coverage 36.10% 47.02% +10.92%
===========================================
Files 63 63
Lines 6658 6681 +23
Branches 1470 1599 +129
===========================================
+ Hits 2404 3142 +738
+ Misses 4056 3284 -772
- Partials 198 255 +57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@sonichi @qingyun-wu this change requires open ai tests. |
Then it needs to be made from the main repo. @WaelKarkoub could you create a branch in the main repo and then make a PR? |
Why are these changes needed?
I noticed some inconsistencies in the formatting of the files, error handling, and type hints. I've only cleaned up the mistakes that I found were "obvious."
Related issue number
Checks