Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Enhancements in agentchat 2.0 #1906

Merged
merged 39 commits into from
Mar 9, 2024
Merged

General Enhancements in agentchat 2.0 #1906

merged 39 commits into from
Mar 9, 2024

Conversation

WaelKarkoub
Copy link
Contributor

@WaelKarkoub WaelKarkoub commented Mar 7, 2024

Why are these changes needed?

I noticed some inconsistencies in the formatting of the files, error handling, and type hints. I've only cleaned up the mistakes that I found were "obvious."

Moved this branch from my fork to the main repo, closing #1729

Related issue number

Checks

@WaelKarkoub
Copy link
Contributor Author

@ekzhu added temp directories for those functions; I tested them locally and they worked as expected. Looking though the docs, we could see PermissionError, just a heads up

@sonichi sonichi added this pull request to the merge queue Mar 9, 2024
Merged via the queue into main with commit 29b9c80 Mar 9, 2024
60 checks passed
@WaelKarkoub WaelKarkoub deleted the better-errors branch March 9, 2024 16:18
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* work in progress

* wip

* groupchat type hints

* clean up

* formatting

* formatting

* clean up

* address comments

* better comment

* updates docstring a_send

* resolve comments

* agent.py back to original format

* resolve more comments

* rename carryover type exception

* revert next_agent changes + keeping UndefinedNextagent

* fixed ciruclar dependencies?

* fix cache tests

---------

Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>
Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants