Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change name from LocalCommandlineCodeExecutor to LocalCommandLineCodeExecutor #1859

Closed
wants to merge 6 commits into from

Conversation

jackgerrits
Copy link
Member

Why are these changes needed?

Fixes a small naming issue

Related issue number

Checks

@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 46.83%. Comparing base (0a79512) to head (40afc4e).

Files Patch % Lines
autogen/coding/local_commandline_code_executor.py 57.89% 14 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1859       +/-   ##
===========================================
+ Coverage   36.03%   46.83%   +10.79%     
===========================================
  Files          63       63               
  Lines        6618     6649       +31     
  Branches     1459     1591      +132     
===========================================
+ Hits         2385     3114      +729     
+ Misses       4039     3283      -756     
- Partials      194      252       +58     
Flag Coverage Δ
unittests 46.75% <60.00%> (+10.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekzhu
Copy link
Collaborator

ekzhu commented Mar 5, 2024

Just some context: we haven't documented this class anywhere yet. So it is a good time to make this type of changes.

@sonichi @qingyun-wu for final approval.

@sonichi
Copy link
Contributor

sonichi commented Mar 5, 2024

This change requires an openai test. Could you make the PR from the upstream repo?

@jackgerrits
Copy link
Member Author

jackgerrits commented Mar 5, 2024

Moved to #1873

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants