Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change name from LocalCommandlineCodeExecutor to LocalCommandLineCodeExecutor #1873

Merged
merged 8 commits into from
Mar 6, 2024

Conversation

jackgerrits
Copy link
Member

@jackgerrits jackgerrits commented Mar 5, 2024

Why are these changes needed?

#1859

Related issue number

Checks

@jackgerrits jackgerrits requested a review from ekzhu March 5, 2024 23:17
@jackgerrits jackgerrits changed the title Fix naming cli exec Change name from LocalCommandlineCodeExecutor to LocalCommandLineCodeExecutor Mar 5, 2024
@jackgerrits jackgerrits requested a review from sonichi March 5, 2024 23:17
@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 54.67%. Comparing base (09a4918) to head (6631697).

Files Patch % Lines
autogen/coding/local_commandline_code_executor.py 57.89% 14 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1873       +/-   ##
===========================================
+ Coverage   36.02%   54.67%   +18.65%     
===========================================
  Files          63       63               
  Lines        6621     6652       +31     
  Branches     1462     1594      +132     
===========================================
+ Hits         2385     3637     +1252     
+ Misses       4041     2713     -1328     
- Partials      195      302      +107     
Flag Coverage Δ
unittests 54.66% <60.00%> (+18.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qingyun-wu qingyun-wu added this pull request to the merge queue Mar 6, 2024
Merged via the queue into main with commit d907821 Mar 6, 2024
53 of 60 checks passed
@jackgerrits jackgerrits deleted the fix_naming_cli_exec branch March 25, 2024 16:00
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
…Executor (microsoft#1873)

* Change name from LocalCommandlineCodeExecutor to LocalCommandLineCodeExecutor

* formatting

* name

* name

* CommandLineCodeResult rename too

* formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants