Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusts send_introductions Type Hint in GroupChat #1912

Merged
merged 5 commits into from
Mar 9, 2024

Conversation

WaelKarkoub
Copy link
Contributor

@WaelKarkoub WaelKarkoub commented Mar 8, 2024

Why are these changes needed?

Closes #1689

Related issue number

Checks

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.62%. Comparing base (78a5a6b) to head (87ca0a5).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1912       +/-   ##
===========================================
+ Coverage   37.09%   47.62%   +10.53%     
===========================================
  Files          64       64               
  Lines        6834     6834               
  Branches     1502     1629      +127     
===========================================
+ Hits         2535     3255      +720     
+ Misses       4082     3311      -771     
- Partials      217      268       +51     
Flag Coverage Δ
unittests 47.49% <100.00%> (+10.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekzhu
Copy link
Collaborator

ekzhu commented Mar 8, 2024

Is there a reason to make it a Draft?

@WaelKarkoub WaelKarkoub marked this pull request as ready for review March 8, 2024 13:08
@WaelKarkoub
Copy link
Contributor Author

@ekzhu just wanted to make sure #1906 gets merged in first

@sonichi sonichi added this pull request to the merge queue Mar 8, 2024
@sonichi sonichi removed this pull request from the merge queue due to a manual request Mar 8, 2024
@sonichi sonichi added this pull request to the merge queue Mar 9, 2024
Merged via the queue into main with commit 08e2615 Mar 9, 2024
49 of 60 checks passed
@WaelKarkoub WaelKarkoub deleted the fix-send_introductions-type branch March 9, 2024 16:18
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev development experience/productivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

using bool type hint for send_introductions
5 participants