refactor: [conversable_agent] remove list of func pointers #2005
+4
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ideally register_reply creates less state in multiple places and avoid having two copies of the same 'func pointer'.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2005 +/- ##
===========================================
+ Coverage 36.87% 48.29% +11.42%
===========================================
Files 67 67
Lines 7068 7065 -3
Branches 1541 1668 +127
===========================================
+ Hits 2606 3412 +806
+ Misses 4234 3365 -869
- Partials 228 288 +60
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Mar 19, 2024
Merged
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
…#2005) * refactor: [conversable_agent] remove list of func pointers Ideally register_reply creates less state in multiple places and avoid having two copies of the same 'func pointer'. * Update conversable_agent.py --------- Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally register_reply creates less state in multiple places and avoid having two copies of the same 'func pointer'.
Why are these changes needed?
Related issue number
Checks