-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify creating a new agent with custom reply function #2095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonichi
requested review from
ekzhu,
afourney,
BeibinLi,
qingyun-wu,
IANTHEREAL,
gagb,
davorrunje and
yousonnet
March 20, 2024 06:09
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2095 +/- ##
===========================================
+ Coverage 36.88% 60.98% +24.09%
===========================================
Files 68 68
Lines 7062 7061 -1
Branches 1540 1669 +129
===========================================
+ Hits 2605 4306 +1701
+ Misses 4228 2365 -1863
- Partials 229 390 +161
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lalo
reviewed
Mar 20, 2024
lalo
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When fixing this test error: https://github.com/microsoft/autogen/actions/runs/8349926930/job/22855210369?pr=2078
I tried to simplify the work needed when creating a new agent with custom reply function.
register_reply
and simplify user's code;Related issue number
#2078 #2005
Checks