Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoGenBench: Handle Ctrl-C more gracefully. #2174

Merged
merged 24 commits into from
Mar 30, 2024
Merged

AutoGenBench: Handle Ctrl-C more gracefully. #2174

merged 24 commits into from
Mar 30, 2024

Conversation

afourney
Copy link
Member

Why are these changes needed?

Previously hitting Ctrl-C during an AutoGenBench run, when operating in Docker, would result in the Docker container being left behind (and possibly still running in some cases). This PR catches the interrupt, and exits more gracefully if possible.

Related issue number

Checks

@afourney afourney added the autogenbench Issues related to AutoGenBench. label Mar 27, 2024
@afourney afourney self-assigned this Mar 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.97%. Comparing base (78aa0eb) to head (4d37ff0).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2174      +/-   ##
==========================================
+ Coverage   37.36%   37.97%   +0.61%     
==========================================
  Files          74       75       +1     
  Lines        7481     7587     +106     
  Branches     1617     1634      +17     
==========================================
+ Hits         2795     2881      +86     
- Misses       4445     4463      +18     
- Partials      241      243       +2     
Flag Coverage Δ
unittests 37.95% <ø> (+0.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jackgerrits jackgerrits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another option is to use atexit. You can see the docker executor for an example

@sonichi sonichi added this pull request to the merge queue Mar 30, 2024
Merged via the queue into main with commit 061a857 Mar 30, 2024
33 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* Prints the version of AutoGenBench from the command line, closing i1458

* Added autogenbench version to timestamp.txt

* Attempting to fix formatting.

* Add a gitignore for autogenbench

* Generalize to read all template dirs from Templates

* AutoGenBench logs telemetry when available.

* Remove spaces if present from template names.

* Bump version.

* Fixed formatting.

* Allow native warning to be skipped. Mount autogen repo in Docker if it can be found (experimental).

* Native execution now occurs in a venv.

* Bump version.

* Fixed a prompt escaping bug evident in GAIA task '6f37996b-2ac7-44b0-8e68-6d28256631b4'

* Updated all scenarios to use template discovery.

* Update with main version of runtime_logging.

* Better handling of Ctrl-C and cleanup of unused containers.

* Even stronger hinting that containers should be removed.

---------

Co-authored-by: gagb <gagb@users.noreply.github.com>
@jackgerrits jackgerrits deleted the autogenbench branch September 25, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autogenbench Issues related to AutoGenBench.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants