Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable provider/extension side copy to clipboard support #23363

Merged
merged 9 commits into from
Jun 9, 2023
Merged

enable provider/extension side copy to clipboard support #23363

merged 9 commits into from
Jun 9, 2023

Conversation

alanrenmsft
Copy link
Contributor

@alanrenmsft alanrenmsft commented Jun 9, 2023 •
edited
Loading

This PR fixes #10123

  1. Use the extension/provider's copy to clipboard implementation if available to optimize the performance.

  2. Add a setting to force to use the ADS side copy to clipboard implementation in case the provider implementation doesn't work on certain Linux platforms.

  3. Provider's own copy to clipboard implementation.
    provider-copy

  4. ADS's copy to clipboard implementation.
    ads-copy

  5. copy small selections
    copy-small-set

STS changes

image

@alanrenmsft alanrenmsft marked this pull request as ready for review June 9, 2023 18:36
@Charles-Gagnon
Copy link
Contributor

Can you include a gif of what it looks like when only copying a small set of values? (e.g. <10 rows with <5 columns)

@alanrenmsft
Copy link
Contributor Author

Can you include a gif of what it looks like when only copying a small set of values? (e.g. <10 rows with <5 columns)

@Charles-Gagnon done

kburtram
kburtram approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@kburtram kburtram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though I didn't see where we disable the provider copy handler in remote mode? I suppose that's only important when we backport the improvement to vscode though.

src/sql/workbench/services/query/common/queryRunner.ts Show resolved Hide resolved
@alanrenmsft alanrenmsft merged commit 5808240 into main Jun 9, 2023
@alanrenmsft alanrenmsft deleted the alanren/copy-data-2 branch June 9, 2023 21:24
@cheenamalhotra cheenamalhotra mentioned this pull request Jul 6, 2023
Closed
@lewis-sanchez lewis-sanchez mentioned this pull request Aug 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kburtram kburtram kburtram approved these changes

@aasimkhan30 aasimkhan30 aasimkhan30 approved these changes

@Charles-Gagnon Charles-Gagnon Charles-Gagnon approved these changes

@brian-harris brian-harris brian-harris approved these changes

@AkshayMata AkshayMata Awaiting requested review from AkshayMata

@raymondtruong raymondtruong Awaiting requested review from raymondtruong raymondtruong is a code owner

@junierch junierch Awaiting requested review from junierch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Azure Data Studio doesn't work reliably when attempting to copy large amounts of data
5 participants
@alanrenmsft @Charles-Gagnon @kburtram @aasimkhan30 @brian-harris