Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert copy clipboard changes from PR #93 #101

Merged
merged 17 commits into from
Sep 12, 2024

Conversation

lewis-sanchez
Copy link
Contributor

@lewis-sanchez lewis-sanchez commented Aug 22, 2024

This PR is a part of microsoft/azuredatastudio#25632

This PR reverts #93

@lewis-sanchez lewis-sanchez changed the title Lewissanchez/copy results to clipboard Add new flag to copy query results to the clipboard Aug 22, 2024
@caohai
Copy link
Member

caohai commented Aug 22, 2024

Screenshot 2024-08-22 at 14 00 44

It appears that the file format is somehow updated in this PR, causing the diff to be the entire file. I can see the actual change if I toggle "ignore whitespaces", can you fix this?

Copy link
Member

@caohai caohai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the diff in the PR to only include the actual changes.

src/main.ts Outdated Show resolved Hide resolved
@lewis-sanchez lewis-sanchez marked this pull request as draft August 28, 2024 00:33
@lewis-sanchez
Copy link
Contributor Author

The setting that allows users to have ADS do the copying to the clipboard in case the query provider's copy implementation doesn't work.
image

The ADS PR that added this setting: microsoft/azuredatastudio#23363

@lewis-sanchez lewis-sanchez marked this pull request as ready for review August 29, 2024 02:15
@lewis-sanchez lewis-sanchez changed the title Add new flag to copy query results to the clipboard Revert copy clipboard changes from PR #93 Aug 29, 2024
@lewis-sanchez lewis-sanchez merged commit 59bae53 into main Sep 12, 2024
4 checks passed
@lewis-sanchez lewis-sanchez deleted the lewissanchez/copy-results-to-clipboard branch September 12, 2024 19:32
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants