Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misaligned arrows when creating infinite arrow using equals sign #406

Closed
dziban303 opened this issue Feb 11, 2021 · 2 comments · Fixed by #410
Closed

Misaligned arrows when creating infinite arrow using equals sign #406

dziban303 opened this issue Feb 11, 2021 · 2 comments · Fixed by #410

Comments

@dziban303
Copy link

dziban303 commented Feb 11, 2021

Environment

Cascadia Code version number: 2102.03
Application (with version) used to display text: Windows Terminal Preview 1.6.10412.0
OS platform and version: Win10 x64 20H2 19042.804
Screen resolution (i.e. 220dpi): 1920x1080, not sure about dpi

Any other software? Happens in Notepad++ v7.9. Also tested Cascadia Code PL 2102.03 with same results.

Steps to reproduce

Add arrows with double angle brackets << or >> while drawing infinite arrows using equals signs ==
The segment with the arrows will appear vertically misaligned vis-à-vis the arrow shaft if the arrows are in the middle of the line body.

E.g., the double arrows in this will appear to be a pixel or two below the rest of the arrow body:
<====<<====>>====|

Expected behavior

Presumably the arrow will line up correctly with the rest of the line body.

Actual behavior

The details of the misalignment (direction and pixel offset) vary depending on the font size. It's almost invisible at 14 point font, but particularly bad at 13. It seems to be perfect at a font size of 22. All other sizes I tested show it.

The effect does not seem to be present when using single angle bracket arrows < and >, and it doesn't seem to appear when using single or double angle brackets on a line made of minus symbols ----

Screenshot showing the behavior (Terminal Preview, Cascadia Code PL, font size 13):
image
It looks like the double arrow portions are a few pixels below the rest of the line.

Another screenshot, zoomed in (as above, but font size 16):
image
In this example, they're both above and below, but in different amounts depending on which direction the arrows are facing.

@aaronbell
Copy link
Collaborator

Thanks! I’ll take a look at the hunting of those glyphs.

DHowett pushed a commit that referenced this issue Feb 25, 2021
A small set of fixes that resolves a couple of new bugs introduced in the latest version, plus other fixes I have been working on. 

## PR Checklist
* [x] Closes #406 - updated anchor type to lock with the other equals-related ligatures
* [x] Closes #408 - corrected component used for glyph to align with Unicode
* [x] Closes #412 - updated locl features removing iacute_j ligature and Catalan substitution
* [x] Closes #414 - increased overlaps of middle glyph for arrow ligatures
* [x] Closes #415 - reduces width of macronbelow
* [x] Closes #416 - rolls back name ID 4 modification as JetBrains cannot process it correctly
* [x] Closes #428 - rolls back variation of the underline to prevent MVAR table generation

## Detailed Description of the Pull Request / Additional comments

Full changelist:
- Repositioned tilde in related ligatures. Previously it was higher than the standard one.
- Added missing vietnamese anchors on acute and grave (futureproofing). 
- Corrected / made consistent greater & less positioning in </> and <$> related ligatures.
- Otherwise reviewed hinting
DHowett added a commit to microsoft/terminal that referenced this issue Feb 25, 2021
This update fixes some issues in Cascadia Code's February update:

microsoft/cascadia-code#406 - updated anchor type to lock with the other equals-related ligatures
microsoft/cascadia-code#408 - corrected component used for glyph to align with Unicode
microsoft/cascadia-code#412 - updated locl features removing iacute_j ligature and Catalan substitution
microsoft/cascadia-code#414 - increased overlaps of middle glyph for arrow ligatures
microsoft/cascadia-code#415 - reduces width of macronbelow
microsoft/cascadia-code#416 - rolls back name ID 4 modification as JetBrains cannot process it correctly
microsoft/cascadia-code#428 - rolls back variation of the underline to prevent MVAR table generation

Full changelist:
* Repositioned tilde in related ligatures. Previously it was higher than the standard one.
* Added missing vietnamese anchors on acute and grave (futureproofing).
* Corrected / made consistent greater & less positioning in </> and <$> related ligatures.
* Otherwise reviewed hinting
DHowett added a commit to microsoft/terminal that referenced this issue Feb 25, 2021
This update fixes some issues in Cascadia Code's February update:

microsoft/cascadia-code#406 - updated anchor type to lock with the other equals-related ligatures
microsoft/cascadia-code#408 - corrected component used for glyph to align with Unicode
microsoft/cascadia-code#412 - updated locl features removing iacute_j ligature and Catalan substitution
microsoft/cascadia-code#414 - increased overlaps of middle glyph for arrow ligatures
microsoft/cascadia-code#415 - reduces width of macronbelow
microsoft/cascadia-code#416 - rolls back name ID 4 modification as JetBrains cannot process it correctly
microsoft/cascadia-code#428 - rolls back variation of the underline to prevent MVAR table generation

Full changelist:
* Repositioned tilde in related ligatures. Previously it was higher than the standard one.
* Added missing vietnamese anchors on acute and grave (futureproofing).
* Corrected / made consistent greater & less positioning in </> and <$> related ligatures.
* Otherwise reviewed hinting
DHowett added a commit to microsoft/terminal that referenced this issue Feb 25, 2021
This update fixes some issues in Cascadia Code's February update:

microsoft/cascadia-code#406 - updated anchor type to lock with the other equals-related ligatures
microsoft/cascadia-code#408 - corrected component used for glyph to align with Unicode
microsoft/cascadia-code#412 - updated locl features removing iacute_j ligature and Catalan substitution
microsoft/cascadia-code#414 - increased overlaps of middle glyph for arrow ligatures
microsoft/cascadia-code#415 - reduces width of macronbelow
microsoft/cascadia-code#416 - rolls back name ID 4 modification as JetBrains cannot process it correctly
microsoft/cascadia-code#428 - rolls back variation of the underline to prevent MVAR table generation

Full changelist:
* Repositioned tilde in related ligatures. Previously it was higher than the standard one.
* Added missing vietnamese anchors on acute and grave (futureproofing).
* Corrected / made consistent greater & less positioning in </> and <$> related ligatures.
* Otherwise reviewed hinting

(cherry picked from commit cb03b97)
DHowett added a commit to microsoft/terminal that referenced this issue Feb 25, 2021
This update fixes some issues in Cascadia Code's February update:

microsoft/cascadia-code#406 - updated anchor type to lock with the other equals-related ligatures
microsoft/cascadia-code#408 - corrected component used for glyph to align with Unicode
microsoft/cascadia-code#412 - updated locl features removing iacute_j ligature and Catalan substitution
microsoft/cascadia-code#414 - increased overlaps of middle glyph for arrow ligatures
microsoft/cascadia-code#415 - reduces width of macronbelow
microsoft/cascadia-code#416 - rolls back name ID 4 modification as JetBrains cannot process it correctly
microsoft/cascadia-code#428 - rolls back variation of the underline to prevent MVAR table generation

Full changelist:
* Repositioned tilde in related ligatures. Previously it was higher than the standard one.
* Added missing vietnamese anchors on acute and grave (futureproofing).
* Corrected / made consistent greater & less positioning in </> and <$> related ligatures.
* Otherwise reviewed hinting

(cherry picked from commit cb03b97)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@dziban303 @aaronbell and others