-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ḵ, Ḻ, Ṉ, Ṯ, ḵ, ḻ, ṉ have a macron below not an underline #415
Comments
Thanks for the feedback, as always. I actually originally had used standard macron widths for these, but decided to change it for the sake of Líl̓wat. Líl̓wat has a character So while the sample I found seemed to indicate use of lowlinecomb, I was concerned that we could end up in a situation where a different glyph, such as macronbelow (which is common in other Salishan scripts) could be used by accident, causing poor rendering. As such, it made sense to set both lowlinecomb and macronbelowcomb to be fullwidth, and overlapping. Having a slightly longer macronbelow is not that problematic, and it is unlikely that two characters with such an accent will ever be next to one another in text other than Líl̓wat, so it felt like an acceptable compromise to ensure quality rendering for Líl̓wat. With your feedback, I thought I'd go back and take a second look. In examining the keyboard layouts provided for St̓át̓imcets / Líl̓wat, it appears that |
Technically, there's also 035F COMBINING DOUBLE MACRON BELOW that could be used to have t͟s with a double macron that doesn't connect left and right. But it doesn't seem to be used in St̓át̓imcets / Líl̓wat data. |
A small set of fixes that resolves a couple of new bugs introduced in the latest version, plus other fixes I have been working on. ## PR Checklist * [x] Closes #406 - updated anchor type to lock with the other equals-related ligatures * [x] Closes #408 - corrected component used for glyph to align with Unicode * [x] Closes #412 - updated locl features removing iacute_j ligature and Catalan substitution * [x] Closes #414 - increased overlaps of middle glyph for arrow ligatures * [x] Closes #415 - reduces width of macronbelow * [x] Closes #416 - rolls back name ID 4 modification as JetBrains cannot process it correctly * [x] Closes #428 - rolls back variation of the underline to prevent MVAR table generation ## Detailed Description of the Pull Request / Additional comments Full changelist: - Repositioned tilde in related ligatures. Previously it was higher than the standard one. - Added missing vietnamese anchors on acute and grave (futureproofing). - Corrected / made consistent greater & less positioning in </> and <$> related ligatures. - Otherwise reviewed hinting
This update fixes some issues in Cascadia Code's February update: microsoft/cascadia-code#406 - updated anchor type to lock with the other equals-related ligatures microsoft/cascadia-code#408 - corrected component used for glyph to align with Unicode microsoft/cascadia-code#412 - updated locl features removing iacute_j ligature and Catalan substitution microsoft/cascadia-code#414 - increased overlaps of middle glyph for arrow ligatures microsoft/cascadia-code#415 - reduces width of macronbelow microsoft/cascadia-code#416 - rolls back name ID 4 modification as JetBrains cannot process it correctly microsoft/cascadia-code#428 - rolls back variation of the underline to prevent MVAR table generation Full changelist: * Repositioned tilde in related ligatures. Previously it was higher than the standard one. * Added missing vietnamese anchors on acute and grave (futureproofing). * Corrected / made consistent greater & less positioning in </> and <$> related ligatures. * Otherwise reviewed hinting
This update fixes some issues in Cascadia Code's February update: microsoft/cascadia-code#406 - updated anchor type to lock with the other equals-related ligatures microsoft/cascadia-code#408 - corrected component used for glyph to align with Unicode microsoft/cascadia-code#412 - updated locl features removing iacute_j ligature and Catalan substitution microsoft/cascadia-code#414 - increased overlaps of middle glyph for arrow ligatures microsoft/cascadia-code#415 - reduces width of macronbelow microsoft/cascadia-code#416 - rolls back name ID 4 modification as JetBrains cannot process it correctly microsoft/cascadia-code#428 - rolls back variation of the underline to prevent MVAR table generation Full changelist: * Repositioned tilde in related ligatures. Previously it was higher than the standard one. * Added missing vietnamese anchors on acute and grave (futureproofing). * Corrected / made consistent greater & less positioning in </> and <$> related ligatures. * Otherwise reviewed hinting
This update fixes some issues in Cascadia Code's February update: microsoft/cascadia-code#406 - updated anchor type to lock with the other equals-related ligatures microsoft/cascadia-code#408 - corrected component used for glyph to align with Unicode microsoft/cascadia-code#412 - updated locl features removing iacute_j ligature and Catalan substitution microsoft/cascadia-code#414 - increased overlaps of middle glyph for arrow ligatures microsoft/cascadia-code#415 - reduces width of macronbelow microsoft/cascadia-code#416 - rolls back name ID 4 modification as JetBrains cannot process it correctly microsoft/cascadia-code#428 - rolls back variation of the underline to prevent MVAR table generation Full changelist: * Repositioned tilde in related ligatures. Previously it was higher than the standard one. * Added missing vietnamese anchors on acute and grave (futureproofing). * Corrected / made consistent greater & less positioning in </> and <$> related ligatures. * Otherwise reviewed hinting (cherry picked from commit cb03b97)
This update fixes some issues in Cascadia Code's February update: microsoft/cascadia-code#406 - updated anchor type to lock with the other equals-related ligatures microsoft/cascadia-code#408 - corrected component used for glyph to align with Unicode microsoft/cascadia-code#412 - updated locl features removing iacute_j ligature and Catalan substitution microsoft/cascadia-code#414 - increased overlaps of middle glyph for arrow ligatures microsoft/cascadia-code#415 - reduces width of macronbelow microsoft/cascadia-code#416 - rolls back name ID 4 modification as JetBrains cannot process it correctly microsoft/cascadia-code#428 - rolls back variation of the underline to prevent MVAR table generation Full changelist: * Repositioned tilde in related ligatures. Previously it was higher than the standard one. * Added missing vietnamese anchors on acute and grave (futureproofing). * Corrected / made consistent greater & less positioning in </> and <$> related ligatures. * Otherwise reviewed hinting (cherry picked from commit cb03b97)
Environment
Steps to reproduce
Use Ḵ, Ḻ, Ṉ, Ṯ, ḵ, ḻ, ṉ in any sequence like ḴḺṈṮḵḻṉ.
Expected behavior
The macron below should not be as wide as the advance width.
It should be like the macron above in ĀĒĪŌṒṐŪȲӢӮ āēīōṓṑūȳӣӯ.
Actual behavior
The macron below is as wide as the advance width in each, causing it to connect when any of these is repeated or next to another of that set.
The Glyphs.app glyph names of those glyphs come from the Unicode names of the characters for example Ḵ, 1E34, is
LATIN CAPITAL LETTER K WITH LINE BELOW. But their canonical decomposition uses 0331 COMBINING MACRON BELOW instead of 0332 COMBINING LOW LINE, for example 1E34 is canonically equivalent to ≡ 004B 0331. The Unicode charts for the Latin Extended Additional Block has the note “In this block the names "WITH LINE BELOW" refer to a macron below the letter.”
0332 COMBINING LOW LINE has the following note in the Unicode charts for the Combining Diachritics Block:
0332 COMBINING LOW LINE "connects on left and right" but 0331 COMBINING MACRON BELOW doesn't. Neither should the macron below in those glyphs.
In practice, the macron below or the macron above can have various widths depending on what letter they are on (narrower on the i, wider on the m), but this is less common and is even less necessary with monospace fonts.
The text was updated successfully, but these errors were encountered: