Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some cursive lowercase glyphs appear to have a different slant than the others #470

Closed
JobLeonard opened this issue May 26, 2021 · 4 comments · Fixed by #511
Closed

Some cursive lowercase glyphs appear to have a different slant than the others #470

JobLeonard opened this issue May 26, 2021 · 4 comments · Fixed by #511

Comments

@JobLeonard
Copy link

Environment

Cascadia Code version number: 2105.24
Application (with version) used to display text: not relevant
OS platform and version: not relevant
Screen resolution (i.e. 220dpi): not relevant

Steps to reproduce

  1. Use Cascadia Code v2105.24
  2. Write something that involves a lowercase L, lowercase Y, and possibly some others

Expected behavior

A consistent slant for every glyph (except for block glyphs and similar "graphic" ones)

Actual behavior

I will use this screenshot of a doc comment to illustrate:

image

In an attempt to highlight the differences in perceived slants I added vertical pipes between the lines, while forcing my editor to use a small line height.

So first of all, I want to acknowledge that this is somewhat subjective, and that I might be alone in "reading" these glyphs this way. Having said that, to me the cursive lowercase L feels almost straight. The other glyphs appear to "align" with the slanted vertical pipe characters above and below their lines (although the lowercase Y also appears a bit less slanted than the rest of the glyphs, but it's not as jarring).

I know this is very nitpicky, and I don't want to criticize the designers of the cursive set - I think their design is cute overall, and I'm aware that font design is an art as much as a science, and more importantly that it's an incredible hassle to get it to "feel" just right. However, when quickly skimming text any cursive L's in the text really stand out a lot to me, kind of like how a single bold glyph among non-bold glyphs would stand out. They don't "disappear" into the whole word but break into individual characters, if that makes sense. And I think it's largely because of this difference in (perceived) slant.

(on a similar note the lowercase R breaks with the x-height in a way that makes dendrogram read a bit "wobbly", but that's probably overdoing the nitpicking)

@aaronbell
Copy link
Collaborator

Thanks for the response! I honestly haven't found that the /l to feel really 'out of slope' with the other letters, but I'll take another look at it.

The /r in particular is really challenging because without that little bit sticking up on the top left, it can be mistaken for an /n at a glance. But then it makes the letter feel taller, especially if the top right part of the /r is at the x-height. So there's a degree of balance there. These cursive forms can be surprisingly tough!

@mrclayman
Copy link

mrclayman commented May 26, 2021

I really dig the new cursive styles. Great job to everybody involved.

That said, I tend to agree with @JobLeonard . I think the lowercase L could have just a wee bit more slant. The lowercase Y seems more or less ok IMO.

Thanks a lot for considering these remarks and a huge thanks again for the lovely job done on the font! ❤️

@genesi5
Copy link

genesi5 commented May 31, 2021

image
Check whether if fontname is set like this. That helped me
Before the fix
image

@JobLeonard
Copy link
Author

@genesi5: was your reply meant to go below #468, where people explicitly ask for a non-cursive font version?

If not: I'm seeing the cursive variant glyphs just fine, I'm just nitpicking a bit on the style of an individual one (but the attempt to help is still appreciated!)

DHowett pushed a commit that referenced this issue Jun 18, 2021
Major update! 

This update includes the brand new Arabic and Hebrew language coverage,
along with a variety of bug fixes to the upright and italic fonts. There
has also been a major overhaul of the Cascadia Code Italic lowercase to
make the forms align better with our vision for the font. Enjoy :). 

Supersedes #491

Cascadia Code
* [x] Closes #84 - Arabic language support added!
* [x] Closes #465 - Hebrew language support added!
* [x] Closes #499 - Adjusted base mark positions / set others to be
  ignored in propagateAnchors

Cascadia Code Italic
* [x] Closes #470 - Adjusted slant on cursive forms to feel a bit better
* [x] Closes #468 - Moved cursive forms to `ss01` / `salt` feature 
* [x] Closes #507 - Changed bar / broken bar to be upright for better
  clarity. All ligature forms adjusted.

Both
* [x] Closes #494 - Adjusted `ƒ` in both upright and italic

- Arabic (and Urdu) support added (design by Mohamad Dakak). See [the
  Arabic features PDF] for the exciting new Arabic ligature
  functionality used in Cascadia Code that gives the font greatly
  improved readability and feel more more akin to a text typeface. Don't
  want all that? Don't worry, Cascadia Mono will house a normal version
  of Arabic. 

- Hebrew support added (design by Liron Lavi Turkenich)
- Fixing a bug in the ccmp feature file and added ccmp to the feature
  set in the build script.
- Deleting the (unused) liga feature file
- Vika has reviewed and improved some forms in Cascadia Code upright. 
- /f, /l, /s, /r (and related forms) have been updated to follow more
  'generic' forms. Previous versions have been moved to ss01 / salt OT
  features.

- Changed design of `ƒ` in upright to align better with the standard
  `f`. In the italic, the `ƒ` has been changed to follow the cursive
  version. When `ss01` is applied, the design of the `f` and `ƒ` are
  swapped, and if the `locl` EWE language setting is applied, the 'f'
  swaps for a straight descender version (with cursive `ƒ`).
  Complicated, but achieves supporting everything.

- Entry and exit strokes across the italic lowercase have been rounded
  to better achieve the fun / playful design language that we intended
  for the italic. Other skeletons have been modified as necessary.
  Cyrillic has also been updated for better consistency with the new
  design. 

- Greek lowercase has been updated per feedback from Gerry Leonidas to
  be more cohesive (No longer a mix between a Monday and Friday font.
  All Friday, all the time)

## Validation Steps Performed
All updated reviewed, hinted, and reviewed again :)

[the Arabic features PDF]: https://github.com/microsoft/cascadia-code/blob/main/doc/Arabic_KeyFeatures.pdf
aaronbell added a commit to aaronbell/cascadia-code that referenced this issue Jun 21, 2021
commit e9aa335
Author: Sayed Arif Uddin Pallab <47639147+sayedarifuddin@users.noreply.github.com>
Date:   Sat Jun 19 00:42:28 2021 +0600

    Replaced Hypen (-) with Dash (–) to maintain symmetric view (microsoft#385)

    Co-authored-by: Aaron <aaronbell@users.noreply.github.com>

commit fb0bce6
Author: Aaron <aaronbell@users.noreply.github.com>
Date:   Fri Jun 18 10:37:03 2021 -0700

    Add Hebrew and Arabic; rework Italic (microsoft#511)

    Major update!

    This update includes the brand new Arabic and Hebrew language coverage,
    along with a variety of bug fixes to the upright and italic fonts. There
    has also been a major overhaul of the Cascadia Code Italic lowercase to
    make the forms align better with our vision for the font. Enjoy :).

    Supersedes microsoft#491

    Cascadia Code
    * [x] Closes microsoft#84 - Arabic language support added!
    * [x] Closes microsoft#465 - Hebrew language support added!
    * [x] Closes microsoft#499 - Adjusted base mark positions / set others to be
      ignored in propagateAnchors

    Cascadia Code Italic
    * [x] Closes microsoft#470 - Adjusted slant on cursive forms to feel a bit better
    * [x] Closes microsoft#468 - Moved cursive forms to `ss01` / `salt` feature
    * [x] Closes microsoft#507 - Changed bar / broken bar to be upright for better
      clarity. All ligature forms adjusted.

    Both
    * [x] Closes microsoft#494 - Adjusted `ƒ` in both upright and italic

    - Arabic (and Urdu) support added (design by Mohamad Dakak). See [the
      Arabic features PDF] for the exciting new Arabic ligature
      functionality used in Cascadia Code that gives the font greatly
      improved readability and feel more more akin to a text typeface. Don't
      want all that? Don't worry, Cascadia Mono will house a normal version
      of Arabic.

    - Hebrew support added (design by Liron Lavi Turkenich)
    - Fixing a bug in the ccmp feature file and added ccmp to the feature
      set in the build script.
    - Deleting the (unused) liga feature file
    - Vika has reviewed and improved some forms in Cascadia Code upright.
    - /f, /l, /s, /r (and related forms) have been updated to follow more
      'generic' forms. Previous versions have been moved to ss01 / salt OT
      features.

    - Changed design of `ƒ` in upright to align better with the standard
      `f`. In the italic, the `ƒ` has been changed to follow the cursive
      version. When `ss01` is applied, the design of the `f` and `ƒ` are
      swapped, and if the `locl` EWE language setting is applied, the 'f'
      swaps for a straight descender version (with cursive `ƒ`).
      Complicated, but achieves supporting everything.

    - Entry and exit strokes across the italic lowercase have been rounded
      to better achieve the fun / playful design language that we intended
      for the italic. Other skeletons have been modified as necessary.
      Cyrillic has also been updated for better consistency with the new
      design.

    - Greek lowercase has been updated per feedback from Gerry Leonidas to
      be more cohesive (No longer a mix between a Monday and Friday font.
      All Friday, all the time)

    ## Validation Steps Performed
    All updated reviewed, hinted, and reviewed again :)

    [the Arabic features PDF]: https://github.com/microsoft/cascadia-code/blob/main/doc/Arabic_KeyFeatures.pdf
aaronbell added a commit to aaronbell/cascadia-code that referenced this issue Jun 23, 2021
commit e9aa335
Author: Sayed Arif Uddin Pallab <47639147+sayedarifuddin@users.noreply.github.com>
Date:   Sat Jun 19 00:42:28 2021 +0600

    Replaced Hypen (-) with Dash (–) to maintain symmetric view (microsoft#385)

    Co-authored-by: Aaron <aaronbell@users.noreply.github.com>

commit fb0bce6
Author: Aaron <aaronbell@users.noreply.github.com>
Date:   Fri Jun 18 10:37:03 2021 -0700

    Add Hebrew and Arabic; rework Italic (microsoft#511)

    Major update!

    This update includes the brand new Arabic and Hebrew language coverage,
    along with a variety of bug fixes to the upright and italic fonts. There
    has also been a major overhaul of the Cascadia Code Italic lowercase to
    make the forms align better with our vision for the font. Enjoy :).

    Supersedes microsoft#491

    Cascadia Code
    * [x] Closes microsoft#84 - Arabic language support added!
    * [x] Closes microsoft#465 - Hebrew language support added!
    * [x] Closes microsoft#499 - Adjusted base mark positions / set others to be
      ignored in propagateAnchors

    Cascadia Code Italic
    * [x] Closes microsoft#470 - Adjusted slant on cursive forms to feel a bit better
    * [x] Closes microsoft#468 - Moved cursive forms to `ss01` / `salt` feature
    * [x] Closes microsoft#507 - Changed bar / broken bar to be upright for better
      clarity. All ligature forms adjusted.

    Both
    * [x] Closes microsoft#494 - Adjusted `ƒ` in both upright and italic

    - Arabic (and Urdu) support added (design by Mohamad Dakak). See [the
      Arabic features PDF] for the exciting new Arabic ligature
      functionality used in Cascadia Code that gives the font greatly
      improved readability and feel more more akin to a text typeface. Don't
      want all that? Don't worry, Cascadia Mono will house a normal version
      of Arabic.

    - Hebrew support added (design by Liron Lavi Turkenich)
    - Fixing a bug in the ccmp feature file and added ccmp to the feature
      set in the build script.
    - Deleting the (unused) liga feature file
    - Vika has reviewed and improved some forms in Cascadia Code upright.
    - /f, /l, /s, /r (and related forms) have been updated to follow more
      'generic' forms. Previous versions have been moved to ss01 / salt OT
      features.

    - Changed design of `ƒ` in upright to align better with the standard
      `f`. In the italic, the `ƒ` has been changed to follow the cursive
      version. When `ss01` is applied, the design of the `f` and `ƒ` are
      swapped, and if the `locl` EWE language setting is applied, the 'f'
      swaps for a straight descender version (with cursive `ƒ`).
      Complicated, but achieves supporting everything.

    - Entry and exit strokes across the italic lowercase have been rounded
      to better achieve the fun / playful design language that we intended
      for the italic. Other skeletons have been modified as necessary.
      Cyrillic has also been updated for better consistency with the new
      design.

    - Greek lowercase has been updated per feedback from Gerry Leonidas to
      be more cohesive (No longer a mix between a Monday and Friday font.
      All Friday, all the time)

    ## Validation Steps Performed
    All updated reviewed, hinted, and reviewed again :)

    [the Arabic features PDF]: https://github.com/microsoft/cascadia-code/blob/main/doc/Arabic_KeyFeatures.pdf
aaronbell added a commit to aaronbell/cascadia-code that referenced this issue Jun 23, 2021
Major update!

This update includes the brand new Arabic and Hebrew language coverage,
along with a variety of bug fixes to the upright and italic fonts. There
has also been a major overhaul of the Cascadia Code Italic lowercase to
make the forms align better with our vision for the font. Enjoy :).

Supersedes microsoft#491

Cascadia Code
* [x] Closes microsoft#84 - Arabic language support added!
* [x] Closes microsoft#465 - Hebrew language support added!
* [x] Closes microsoft#499 - Adjusted base mark positions / set others to be
  ignored in propagateAnchors

Cascadia Code Italic
* [x] Closes microsoft#470 - Adjusted slant on cursive forms to feel a bit better
* [x] Closes microsoft#468 - Moved cursive forms to `ss01` / `salt` feature
* [x] Closes microsoft#507 - Changed bar / broken bar to be upright for better
  clarity. All ligature forms adjusted.

Both
* [x] Closes microsoft#494 - Adjusted `ƒ` in both upright and italic

- Arabic (and Urdu) support added (design by Mohamad Dakak). See [the
  Arabic features PDF] for the exciting new Arabic ligature
  functionality used in Cascadia Code that gives the font greatly
  improved readability and feel more more akin to a text typeface. Don't
  want all that? Don't worry, Cascadia Mono will house a normal version
  of Arabic.

- Hebrew support added (design by Liron Lavi Turkenich)
- Fixing a bug in the ccmp feature file and added ccmp to the feature
  set in the build script.
- Deleting the (unused) liga feature file
- Vika has reviewed and improved some forms in Cascadia Code upright.
- /f, /l, /s, /r (and related forms) have been updated to follow more
  'generic' forms. Previous versions have been moved to ss01 / salt OT
  features.

- Changed design of `ƒ` in upright to align better with the standard
  `f`. In the italic, the `ƒ` has been changed to follow the cursive
  version. When `ss01` is applied, the design of the `f` and `ƒ` are
  swapped, and if the `locl` EWE language setting is applied, the 'f'
  swaps for a straight descender version (with cursive `ƒ`).
  Complicated, but achieves supporting everything.

- Entry and exit strokes across the italic lowercase have been rounded
  to better achieve the fun / playful design language that we intended
  for the italic. Other skeletons have been modified as necessary.
  Cyrillic has also been updated for better consistency with the new
  design.

- Greek lowercase has been updated per feedback from Gerry Leonidas to
  be more cohesive (No longer a mix between a Monday and Friday font.
  All Friday, all the time)

All updated reviewed, hinted, and reviewed again :)

[the Arabic features PDF]: https://github.com/microsoft/cascadia-code/blob/main/doc/Arabic_KeyFeatures.pdf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants