-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hebrew and Arabic; rework Italic #511
Conversation
…ances For whatever reason glyphslib sets the familyName of the font to include the "Italic" name. I had corrected the variable font instance, but not the static instances.
Double-checked to make sure that the hinting didn't break in fixing these.
I was there. I updated it.
Still need to hint, but moving along?
- resolving more interpolation fun - updating hints
- Fixing a bug in the ccmp feature file - Deleting the (unused) liga feature file - Adding ccmp to the feature set in the build script.
- /f, /l, /s, /r have been updated to follow more 'generic' forms. - previous versions have been moved to ss01 / salt OT features. - all related glyphs have been similarly adjusted.
Useful for when the day is <10!
Showing off the alternate style.
Good luck @DHowett |
That's the most ominous pull request invitation I've ever received. |
Ooh, interested in what changed here!
I love these terms very much. |
Updating build number :)
@aaronbell Thank you soo much for taking everyone's views on board, but still keeping the fun and playful feel of the italics that give Cascadia Code soooo much character!
Your efforts are appreciated from this guy here... |
One person I asked about the new italic (non-cursive) expressed a concern about the /l looking a bit un- I find that I'm always thrown off when I see the Something about that doesn't feel right to me, and I'm a bit reminded of it with our new one. I dunno. All in my head? |
I do think I like that more :) (I'll also ask the opinion of the other person who had a comment :)) Yeah -- it seems a hard one to get right! |
@aaronbell I'm ready to merge this if you are! |
🚀🚀🚀🚀🚀 |
you rock! |
commit e9aa335 Author: Sayed Arif Uddin Pallab <47639147+sayedarifuddin@users.noreply.github.com> Date: Sat Jun 19 00:42:28 2021 +0600 Replaced Hypen (-) with Dash (–) to maintain symmetric view (microsoft#385) Co-authored-by: Aaron <aaronbell@users.noreply.github.com> commit fb0bce6 Author: Aaron <aaronbell@users.noreply.github.com> Date: Fri Jun 18 10:37:03 2021 -0700 Add Hebrew and Arabic; rework Italic (microsoft#511) Major update! This update includes the brand new Arabic and Hebrew language coverage, along with a variety of bug fixes to the upright and italic fonts. There has also been a major overhaul of the Cascadia Code Italic lowercase to make the forms align better with our vision for the font. Enjoy :). Supersedes microsoft#491 Cascadia Code * [x] Closes microsoft#84 - Arabic language support added! * [x] Closes microsoft#465 - Hebrew language support added! * [x] Closes microsoft#499 - Adjusted base mark positions / set others to be ignored in propagateAnchors Cascadia Code Italic * [x] Closes microsoft#470 - Adjusted slant on cursive forms to feel a bit better * [x] Closes microsoft#468 - Moved cursive forms to `ss01` / `salt` feature * [x] Closes microsoft#507 - Changed bar / broken bar to be upright for better clarity. All ligature forms adjusted. Both * [x] Closes microsoft#494 - Adjusted `ƒ` in both upright and italic - Arabic (and Urdu) support added (design by Mohamad Dakak). See [the Arabic features PDF] for the exciting new Arabic ligature functionality used in Cascadia Code that gives the font greatly improved readability and feel more more akin to a text typeface. Don't want all that? Don't worry, Cascadia Mono will house a normal version of Arabic. - Hebrew support added (design by Liron Lavi Turkenich) - Fixing a bug in the ccmp feature file and added ccmp to the feature set in the build script. - Deleting the (unused) liga feature file - Vika has reviewed and improved some forms in Cascadia Code upright. - /f, /l, /s, /r (and related forms) have been updated to follow more 'generic' forms. Previous versions have been moved to ss01 / salt OT features. - Changed design of `ƒ` in upright to align better with the standard `f`. In the italic, the `ƒ` has been changed to follow the cursive version. When `ss01` is applied, the design of the `f` and `ƒ` are swapped, and if the `locl` EWE language setting is applied, the 'f' swaps for a straight descender version (with cursive `ƒ`). Complicated, but achieves supporting everything. - Entry and exit strokes across the italic lowercase have been rounded to better achieve the fun / playful design language that we intended for the italic. Other skeletons have been modified as necessary. Cyrillic has also been updated for better consistency with the new design. - Greek lowercase has been updated per feedback from Gerry Leonidas to be more cohesive (No longer a mix between a Monday and Friday font. All Friday, all the time) ## Validation Steps Performed All updated reviewed, hinted, and reviewed again :) [the Arabic features PDF]: https://github.com/microsoft/cascadia-code/blob/main/doc/Arabic_KeyFeatures.pdf
commit e9aa335 Author: Sayed Arif Uddin Pallab <47639147+sayedarifuddin@users.noreply.github.com> Date: Sat Jun 19 00:42:28 2021 +0600 Replaced Hypen (-) with Dash (–) to maintain symmetric view (microsoft#385) Co-authored-by: Aaron <aaronbell@users.noreply.github.com> commit fb0bce6 Author: Aaron <aaronbell@users.noreply.github.com> Date: Fri Jun 18 10:37:03 2021 -0700 Add Hebrew and Arabic; rework Italic (microsoft#511) Major update! This update includes the brand new Arabic and Hebrew language coverage, along with a variety of bug fixes to the upright and italic fonts. There has also been a major overhaul of the Cascadia Code Italic lowercase to make the forms align better with our vision for the font. Enjoy :). Supersedes microsoft#491 Cascadia Code * [x] Closes microsoft#84 - Arabic language support added! * [x] Closes microsoft#465 - Hebrew language support added! * [x] Closes microsoft#499 - Adjusted base mark positions / set others to be ignored in propagateAnchors Cascadia Code Italic * [x] Closes microsoft#470 - Adjusted slant on cursive forms to feel a bit better * [x] Closes microsoft#468 - Moved cursive forms to `ss01` / `salt` feature * [x] Closes microsoft#507 - Changed bar / broken bar to be upright for better clarity. All ligature forms adjusted. Both * [x] Closes microsoft#494 - Adjusted `ƒ` in both upright and italic - Arabic (and Urdu) support added (design by Mohamad Dakak). See [the Arabic features PDF] for the exciting new Arabic ligature functionality used in Cascadia Code that gives the font greatly improved readability and feel more more akin to a text typeface. Don't want all that? Don't worry, Cascadia Mono will house a normal version of Arabic. - Hebrew support added (design by Liron Lavi Turkenich) - Fixing a bug in the ccmp feature file and added ccmp to the feature set in the build script. - Deleting the (unused) liga feature file - Vika has reviewed and improved some forms in Cascadia Code upright. - /f, /l, /s, /r (and related forms) have been updated to follow more 'generic' forms. Previous versions have been moved to ss01 / salt OT features. - Changed design of `ƒ` in upright to align better with the standard `f`. In the italic, the `ƒ` has been changed to follow the cursive version. When `ss01` is applied, the design of the `f` and `ƒ` are swapped, and if the `locl` EWE language setting is applied, the 'f' swaps for a straight descender version (with cursive `ƒ`). Complicated, but achieves supporting everything. - Entry and exit strokes across the italic lowercase have been rounded to better achieve the fun / playful design language that we intended for the italic. Other skeletons have been modified as necessary. Cyrillic has also been updated for better consistency with the new design. - Greek lowercase has been updated per feedback from Gerry Leonidas to be more cohesive (No longer a mix between a Monday and Friday font. All Friday, all the time) ## Validation Steps Performed All updated reviewed, hinted, and reviewed again :) [the Arabic features PDF]: https://github.com/microsoft/cascadia-code/blob/main/doc/Arabic_KeyFeatures.pdf
Major update! This update includes the brand new Arabic and Hebrew language coverage, along with a variety of bug fixes to the upright and italic fonts. There has also been a major overhaul of the Cascadia Code Italic lowercase to make the forms align better with our vision for the font. Enjoy :). Supersedes microsoft#491 Cascadia Code * [x] Closes microsoft#84 - Arabic language support added! * [x] Closes microsoft#465 - Hebrew language support added! * [x] Closes microsoft#499 - Adjusted base mark positions / set others to be ignored in propagateAnchors Cascadia Code Italic * [x] Closes microsoft#470 - Adjusted slant on cursive forms to feel a bit better * [x] Closes microsoft#468 - Moved cursive forms to `ss01` / `salt` feature * [x] Closes microsoft#507 - Changed bar / broken bar to be upright for better clarity. All ligature forms adjusted. Both * [x] Closes microsoft#494 - Adjusted `ƒ` in both upright and italic - Arabic (and Urdu) support added (design by Mohamad Dakak). See [the Arabic features PDF] for the exciting new Arabic ligature functionality used in Cascadia Code that gives the font greatly improved readability and feel more more akin to a text typeface. Don't want all that? Don't worry, Cascadia Mono will house a normal version of Arabic. - Hebrew support added (design by Liron Lavi Turkenich) - Fixing a bug in the ccmp feature file and added ccmp to the feature set in the build script. - Deleting the (unused) liga feature file - Vika has reviewed and improved some forms in Cascadia Code upright. - /f, /l, /s, /r (and related forms) have been updated to follow more 'generic' forms. Previous versions have been moved to ss01 / salt OT features. - Changed design of `ƒ` in upright to align better with the standard `f`. In the italic, the `ƒ` has been changed to follow the cursive version. When `ss01` is applied, the design of the `f` and `ƒ` are swapped, and if the `locl` EWE language setting is applied, the 'f' swaps for a straight descender version (with cursive `ƒ`). Complicated, but achieves supporting everything. - Entry and exit strokes across the italic lowercase have been rounded to better achieve the fun / playful design language that we intended for the italic. Other skeletons have been modified as necessary. Cyrillic has also been updated for better consistency with the new design. - Greek lowercase has been updated per feedback from Gerry Leonidas to be more cohesive (No longer a mix between a Monday and Friday font. All Friday, all the time) All updated reviewed, hinted, and reviewed again :) [the Arabic features PDF]: https://github.com/microsoft/cascadia-code/blob/main/doc/Arabic_KeyFeatures.pdf
@DHowett Was wondering what the plan is to release this update :). I'm looking forward to folks being able to use the Arabic / Hebrew! |
Now that we're no longer holding back communication (and release notes and stuff) for the recent announcements, I'm hoping to have an update out shortly. |
'may' :) Look forward to it! |
Summary of the Pull Request
Major update!
This update includes the brand new Arabic and Hebrew language coverage, along with a variety of bug fixes to the upright and italic fonts. There has also been a major overhaul of the Cascadia Code Italic lowercase to make the forms align better with our vision for the font. Enjoy :).
Supersedes #491
PR Checklist
Cascadia Code
Cascadia Code Italic
ss01
/salt
featureBoth
ƒ
in both upright and italicDetailed Description of the Pull Request / Additional comments
New default forms
Cursive forms (
ss01
/salt
)ƒ
in upright to align better with the standardf
. In the italic, theƒ
has been changed to follow the cursive version. Whenss01
is applied, the design of thef
andƒ
are swapped, and if thelocl
EWE language setting is applied, the 'f' swaps for a straight descender version (with cursiveƒ
). Complicated, but achieves supporting everything.old
new
Validation Steps Performed
All updated reviewed, hinted, and reviewed again :)