Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plain integer version number should be accepted by CodePush. #377

Closed
benjaminb10 opened this issue Jan 27, 2017 · 1 comment
Closed

Plain integer version number should be accepted by CodePush. #377

benjaminb10 opened this issue Jan 27, 2017 · 1 comment
Assignees
@max-mironov
Labels
enhancement

Comments

@benjaminb10
Copy link

benjaminb10 commented Jan 27, 2017 •
edited
Loading

My app version number is 1
I prefer 1 to 1.0
My next version will be number 2, then 3, etc.
I prefer 1, 2, 3 to 1.0, 1.1, 1.2, etc.
It's here a personal choice and off topic. Just Like what Messenger app from Facebook does, they are at their version number 100 (plain integer 100 and not 100.0)

But when I put 1 for the value of CFBundleShortVersionString in my Info.plist file,
I have this CodePush error:

[Error] The "CFBundleShortVersionString" key in the "ios/MyApp/Info.plist" file needs to specify a valid semver string, containing both a major and minor version (e.g. 1.3.2, 1.1).

Why does CodePush block a plain integer version number?
It should allow me to use 1 as a version number.
@benjaminb10 benjaminb10 mentioned this issue Jan 27, 2017
Closed
@max-mironov max-mironov self-assigned this Feb 17, 2017
max-mironov pushed a commit to max-mironov/code-push that referenced this issue Apr 12, 2017
Add ability to use plain integer number for app version
53ad53f 
See microsoft#377 for details
@max-mironov max-mironov mentioned this issue Apr 12, 2017
Merged
max-mironov pushed a commit that referenced this issue Jul 19, 2017
Plain integer number (#429)
c5a294d 
* Improved messages to make intention of creating different apps for different platforms more clear

Due to multiple requests in discord chanel, microsoft/react-native-code-push#723, microsoft/react-native-code-push#717

* Minor tweak for readme

* Add ability to use plain integer number for app version

See #377 for details
@max-mironov
Copy link
Contributor

Closing this as PR #429 was merged to Master.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@max-mironov max-mironov

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@benjaminb10 @sergey-akhalkov @max-mironov