Prevent keyboard navigation to hidden tab #6789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-akinc
requested review from
EisenbergEffect,
chrisdholt and
nicholasrice
as code owners
nicholasrice
reviewed
Aug 1, 2023
change/@microsoft-fast-foundation-7d8d0430-523b-473a-af77-e2bcf0bc6e38.json
Outdated
Show resolved
Hide resolved
nicholasrice
reviewed
Aug 1, 2023
change/@microsoft-fast-foundation-7d8d0430-523b-473a-af77-e2bcf0bc6e38.json
Outdated
Show resolved
Hide resolved
nicholasrice
approved these changes
Aug 1, 2023
chrisdholt
approved these changes
Aug 2, 2023
|
Thanks for this and including tests! |
m-akinc
added a commit
to m-akinc/fast
that referenced
this pull request
Aug 2, 2023
* Prevent keyboard navigation to hidden tab * Change files * Fix issue with Home/End * use hasAttribute * Update change/@microsoft-fast-foundation-7d8d0430-523b-473a-af77-e2bcf0bc6e38.json * Update change/@microsoft-fast-foundation-7d8d0430-523b-473a-af77-e2bcf0bc6e38.json --------- Co-authored-by: Nicholas Rice <3213292+nicholasrice@users.noreply.github.com>
m-akinc
added a commit
to m-akinc/fast
that referenced
this pull request
Aug 2, 2023
* Prevent keyboard navigation to hidden tab * Change files * Fix issue with Home/End * use hasAttribute * Update change/@microsoft-fast-foundation-7d8d0430-523b-473a-af77-e2bcf0bc6e38.json * Update change/@microsoft-fast-foundation-7d8d0430-523b-473a-af77-e2bcf0bc6e38.json --------- Co-authored-by: Nicholas Rice <3213292+nicholasrice@users.noreply.github.com>
|
@chrisdholt What do I need to do to get this and another related fix (84726aa) cherry-picked into |
I tried to quickly cherry-pick this last night but there were conflicts due to package changes. I might suggest just opening a new pr against archives/fast-element-1 for simplicity. Happy to rebase it myself, but that may be quicker :) |
chrisdholt
added a commit
that referenced
this pull request
Aug 10, 2023
* [cherry-pick] fix(tabs): home and end navigation (#6298) * fix(tabs): home and end navigation * Change files * Update packages/web-components/fast-foundation/src/tabs/stories/tabs.stories.ts Co-authored-by: John Kreitlow <863023+radium-v@users.noreply.github.com> * apply pr comments * Revert "apply pr comments" This reverts commit 09a6523. * apply pr comment * Update change/@microsoft-fast-foundation-dc08ca7b-be41-4f42-a66c-c0874376b4a2.json Co-authored-by: John Kreitlow <863023+radium-v@users.noreply.github.com> Co-authored-by: John Kreitlow <863023+radium-v@users.noreply.github.com> Co-authored-by: Chris Holt <chhol@microsoft.com> * [cherry-pick] Prevent keyboard navigation to hidden tab (#6789) * Prevent keyboard navigation to hidden tab * Change files * Fix issue with Home/End * use hasAttribute * Update change/@microsoft-fast-foundation-7d8d0430-523b-473a-af77-e2bcf0bc6e38.json * Update change/@microsoft-fast-foundation-7d8d0430-523b-473a-af77-e2bcf0bc6e38.json --------- Co-authored-by: Nicholas Rice <3213292+nicholasrice@users.noreply.github.com> * Update change files --------- Co-authored-by: Mathieu Lavoie <44816587+m4thieulavoie@users.noreply.github.com> Co-authored-by: John Kreitlow <863023+radium-v@users.noreply.github.com> Co-authored-by: Chris Holt <chhol@microsoft.com> Co-authored-by: Nicholas Rice <3213292+nicholasrice@users.noreply.github.com>
janechu
pushed a commit
that referenced
this pull request
Jun 10, 2024
* Prevent keyboard navigation to hidden tab * Change files * Fix issue with Home/End * use hasAttribute * Update change/@microsoft-fast-foundation-7d8d0430-523b-473a-af77-e2bcf0bc6e38.json * Update change/@microsoft-fast-foundation-7d8d0430-523b-473a-af77-e2bcf0bc6e38.json --------- Co-authored-by: Nicholas Rice <3213292+nicholasrice@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
There is a bug in the tabs component where you can use the keyboard (arrows, home/end) to navigate to a hidden tab. None of the tabs will appear as active, but the tab panel for the hidden tab will be displayed.
🎫 Issues
NA
👩💻 Reviewer Notes
📑 Test Plan
There is a TODO in the tabs test file for creating tests for keyboard navigation. I have created just two tests to exercise the use cases I fixed.
✅ Checklist
General
$ yarn changeComponent-specific
⏭ Next Steps
I would like this change cherry-picked into the
archives/fast-element-1branch.