[cherry-pick] two tab navigation fixes #6793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(tabs): home and end navigation * Change files * Update packages/web-components/fast-foundation/src/tabs/stories/tabs.stories.ts Co-authored-by: John Kreitlow <863023+radium-v@users.noreply.github.com> * apply pr comments * Revert "apply pr comments" This reverts commit 09a6523. * apply pr comment * Update change/@microsoft-fast-foundation-dc08ca7b-be41-4f42-a66c-c0874376b4a2.json Co-authored-by: John Kreitlow <863023+radium-v@users.noreply.github.com> Co-authored-by: John Kreitlow <863023+radium-v@users.noreply.github.com> Co-authored-by: Chris Holt <chhol@microsoft.com>
* Prevent keyboard navigation to hidden tab * Change files * Fix issue with Home/End * use hasAttribute * Update change/@microsoft-fast-foundation-7d8d0430-523b-473a-af77-e2bcf0bc6e38.json * Update change/@microsoft-fast-foundation-7d8d0430-523b-473a-af77-e2bcf0bc6e38.json --------- Co-authored-by: Nicholas Rice <3213292+nicholasrice@users.noreply.github.com>
m-akinc
requested review from
EisenbergEffect,
chrisdholt and
nicholasrice
as code owners
chrisdholt
approved these changes
Aug 8, 2023
chrisdholt
approved these changes
Aug 9, 2023
|
@chrisdholt can this be merged, or is it still waiting on approvals? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Cherry-picking two fixes for bugs in the tab control's keyboard navigation.
Commits:
84726aa
50dba9c