Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing: UIHostingController does not automatically resize to hug subviews in iOS 15.0 #759

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

sophialee0416
Copy link
Contributor

@sophialee0416 sophialee0416 commented Oct 15, 2021

Platforms Impacted

  • iOS
  • macOS

Description of changes

Addressing a bug discovered here: #648 (comment)
UIHostingController in iOS 15 does not automatically resize to hug subviews if they are dynamically changing.
Note: The small avatar animation jumps + holes in cutout is a bug separate from this PR and is currently being fixed in #648

Verification

Below are recordings tested in iOS 15, but manual tests in iOS 13 + 14 were performed as well.

Before After
before ezgif com-gif-maker-2

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

@mischreiber mischreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing off assuming this was also tested in iOS 13 and 14 simulators!

@sophialee0416
Copy link
Contributor Author

Signing off assuming this was also tested in iOS 13 and 14 simulators!

Will mention that in the description!

@sophialee0416 sophialee0416 merged commit 8192db4 into microsoft:main Oct 15, 2021
@sophialee0416 sophialee0416 deleted the hostingFix branch October 15, 2021 21:24
sophialee0416 added a commit to sophialee0416/fluentui-apple that referenced this pull request Oct 15, 2021
@rdeassis
Copy link
Contributor

Please test this change thoroughly in different device types, orientation changes and iOS versions. We need to be 100% sure that this will not cause an undesired side effect on other controls that are already being used by the client apps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants