Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ControlHostingView's hostingController to wrap subview #1831

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

joannaquu
Copy link
Contributor

@joannaquu joannaquu commented Jul 18, 2023

Platforms Impacted

  • iOS
  • macOS

Description of changes

#1690 deprecated FluentUIHostingController in iOS 16, which removed #759, a change that fixed an issue where UIHostingController didn't resize when the subviews changed. This caused a bug with MSFAvatarGroup where the VoiceOver frame would not wrap the entire avatarGroup when a new avatar was added. With iOS 16, setting the UIHostingController's sizingOptions fixes this issue.

Binary change

Total increase: 1,888 bytes
Total decrease: 0 bytes

File Before After Delta
Total 46,571,392 bytes 46,573,280 bytes ⚠️ 1,888 bytes
Full breakdown
File Before After Delta
ControlHostingView.o 121,248 bytes 122,984 bytes ⚠️ 1,736 bytes
__.SYMDEF 2,883,288 bytes 2,883,440 bytes ⚠️ 152 bytes

Verification

Visual Verification
Before After
before after

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: codeflow:open?pullrequest=#1831

@joannaquu joannaquu requested a review from a team as a code owner July 18, 2023 20:21
@joannaquu joannaquu merged commit 493aaa5 into microsoft:main Jul 18, 2023
@joannaquu joannaquu deleted the joannaqu/hosting-controller branch July 18, 2023 22:51
joannaquu added a commit to joannaquu/fluentui-apple that referenced this pull request Jul 20, 2023
joannaquu added a commit that referenced this pull request Jul 20, 2023
[main_0.20] Cherry-pick #1831, #1826, and #1833
@nodes11 nodes11 mentioned this pull request Aug 21, 2023
11 tasks
@joannaquu joannaquu mentioned this pull request Jun 7, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants