Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust header color for popup menu #1833

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

harrieshin
Copy link
Contributor

@harrieshin harrieshin commented Jul 20, 2023

Platforms Impacted

  • iOS
  • macOS

Description of changes

adjust the popupmenu headerfooterview background color to be clear to blend better with the overall drawercontroller

Binary change

Total increase: 2,200 bytes
Total decrease: 0 bytes

File Before After Delta
Total 29,686,720 bytes 29,688,920 bytes ⚠️ 2,200 bytes
Full breakdown
File Before After Delta
PopupMenuController.o 380,256 bytes 382,072 bytes ⚠️ 1,816 bytes
__.SYMDEF 4,497,496 bytes 4,497,880 bytes ⚠️ 384 bytes

Verification

Before After
image image

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: codeflow:open?pullrequest=#1833

@harrieshin harrieshin requested a review from a team as a code owner July 20, 2023 00:55
@harrieshin harrieshin merged commit 025b00e into microsoft:main Jul 20, 2023
joannaquu pushed a commit to joannaquu/fluentui-apple that referenced this pull request Jul 20, 2023
joannaquu added a commit that referenced this pull request Jul 20, 2023
[main_0.20] Cherry-pick #1831, #1826, and #1833
@nodes11 nodes11 mentioned this pull request Aug 21, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants