Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main_0.20] Cherry-pick #1831, #1826, and #1833 #1834

Merged
merged 3 commits into from
Jul 20, 2023
Merged

[main_0.20] Cherry-pick #1831, #1826, and #1833 #1834

merged 3 commits into from
Jul 20, 2023

Conversation

joannaquu
Copy link
Contributor

@joannaquu joannaquu commented Jul 20, 2023 •
edited by microsoft-github-policy-service bot
Loading

Platforms Impacted

  • iOS
  • macOS

Description of changes

Cherry-pick of the following PRs

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: codeflow:open?pullrequest=#1834

joannaquu and others added 3 commits July 20, 2023 14:47
@joannaquu
Update ControlHostingView's hostingController to wrap subview (micros…
98ed57a 
…oft#1831)
@nodes11 @joannaquu
Buttons in scrollable CommandBar are filling containing view equally,…
59b6852 
… creating undesirable layout (microsoft#1826)

* Buttons in scrollable CommandBar are using .fillEqually distribution

* Updates

* Update

* Remove duplicate constraint
@harrieshin @joannaquu
adjust header color for popup menu (microsoft#1833)
2f82291
@joannaquu joannaquu requested a review from a team as a code owner July 20, 2023 18:59
@joannaquu joannaquu changed the title [main_0.19] Cherry-pick #1831, #1826, and #1833 [main_0.20] Cherry-pick #1831, #1826, and #1833 Jul 20, 2023
@joannaquu joannaquu added the New API This PR introduces new API label Jul 20, 2023
@joannaquu joannaquu merged commit 814edd1 into microsoft:main_0.20 Jul 20, 2023
@joannaquu joannaquu deleted the joannaqu/cherry-pick branch July 20, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huwilkes huwilkes huwilkes approved these changes

@harrieshin harrieshin harrieshin approved these changes

Assignees
No one assigned
Labels
Cherry-pick 🍒 New API This PR introduces new API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joannaquu @harrieshin @huwilkes @nodes11