(web-components) Use ElementInternals for TextInput elements
#31201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
Should we pull the label from within the control with this change? |
janechu
approved these changes
Apr 25, 2024
change/@fluentui-web-components-7fcf0c62-7015-4e62-b867-951d528a3a4c.json
Outdated
Show resolved
Hide resolved
radium-v
force-pushed
the
users/radium-v/web-components-v3-text-input
branch
from
64a35b4
to
070313f
Compare
radium-v
force-pushed
the
web-components-v3
branch
2 times, most recently
from
707be68
to
3ba33e2
Compare
radium-v
force-pushed
the
users/radium-v/web-components-v3-text-input
branch
from
070313f
to
af1d832
Compare
radium-v
force-pushed
the
web-components-v3
branch
from
8f49a44
to
cb6fdf3
Compare
radium-v
force-pushed
the
users/radium-v/web-components-v3-text-input
branch
from
af1d832
to
e20f6ef
Compare
|
This will need to be pointed to |
radium-v
force-pushed
the
users/radium-v/web-components-v3-text-input
branch
from
e20f6ef
to
3af5dd9
Compare
📊 Bundle size report✅ No changes found |
fabricteam
reviewed
May 14, 2024
change/@fluentui-web-components-7fcf0c62-7015-4e62-b867-951d528a3a4c.json
Show resolved
Hide resolved
radium-v
force-pushed
the
users/radium-v/web-components-v3-text-input
branch
2 times, most recently
from
3f8fe39
to
ccc025b
Compare
@chrisdholt due to cross-root ARIA limitations, the label has to be part of the component. I gave a custom |
radium-v
force-pushed
the
users/radium-v/web-components-v3-text-input
branch
2 times, most recently
from
5b79d8d
to
ce3b7af
Compare
chrisdholt
approved these changes
May 23, 2024
davatron5000
approved these changes
May 23, 2024
radium-v
force-pushed
the
users/radium-v/web-components-v3-text-input
branch
from
ce3b7af
to
d5d078b
Compare
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
May 28, 2024
* master: (49 commits) Update focus order in sankey chart for vertical navigation (microsoft#31469) chore: use new performant 'type-check' for v9 libaries (microsoft#31454) applying package updates fix(Timepicker-compat): clearIcon not working in freeform (microsoft#31324) chore: re-enable lint rule (microsoft#31459) feat(react-tag-picker): adds text property to TagPickerOption (microsoft#31474) feat(recipes): create package with initial implementation (moved from /apps) (microsoft#31386) applying package updates applying package updates chore: revert globals changes (microsoft#31470) (web-components) Use `ElementInternals` for TextInput elements (microsoft#31201) chore:(docs) Update and migrate component implementation guide (microsoft#31398) disallow all globals in Fluent v9 (microsoft#30967) chore:(react-nav-preview) Recomposing more components and some pixel pushing (microsoft#31387) fix(pr-deploy-site): explicitly set types to not include whole @types/* globals which are causing issues with addition of @types/web (microsoft#31465) fix(recipes-react-components): explicitly set types to not include whole @types/* globals which are cauising issues with addition of @types/web (microsoft#31463) applying package updates applying package updates applying package updates Update IconDirectionContextProvider import to import from specific path (microsoft#31006) ...
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Currently, form-associated custom elements use the
FormAssociatedclass mixin. This mixin is heavy and duplicative, being copied wholesale for every component which utilizes it. WhileFormAssociatedincludes minimal support forElementInternals, the implementation isn't fully baked.New Behavior
Improvements:
<fluent-text-input>custom element to useElementInternalsby default. An optional polyfill may be added in the near future, as more components transition to use ElementInternals.TextInputcomponent.