-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-drawer): allow aside tag for Drawer components #31434
feat(react-drawer): allow aside tag for Drawer components #31434
Conversation
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
FluentProviderWithTheme | virtual-rerender | 40 | 41 | 10 | Possible regression |
All results
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 632 | 656 | 5000 | |
Button | mount | 319 | 305 | 5000 | |
Field | mount | 1172 | 1156 | 5000 | |
FluentProvider | mount | 731 | 719 | 5000 | |
FluentProviderWithTheme | mount | 92 | 95 | 10 | |
FluentProviderWithTheme | virtual-rerender | 40 | 41 | 10 | Possible regression |
FluentProviderWithTheme | virtual-rerender-with-unmount | 92 | 93 | 10 | |
MakeStyles | mount | 864 | 872 | 50000 | |
Persona | mount | 1767 | 1750 | 5000 | |
SpinButton | mount | 1465 | 1453 | 5000 | |
SwatchPicker | mount | 1602 | 1569 | 5000 |
📊 Bundle size report
Unchanged fixtures
|
* master: applying package updates applying package updates docs: Surfacing `Dropdown` and `Combobox` prop comments to docsite (microsoft#31430) (web-components) call click in button keydownHandler (microsoft#31428) Modify data and color codes for examples to fix accessibility issues (microsoft#31425) chore(deps): bump semver from 5.7.1 to 6.3.1 (microsoft#31420) applying package updates Improve gauge chart screen reader accessibility (microsoft#26682) applying package updates applying package updates
* master: (49 commits) Update focus order in sankey chart for vertical navigation (microsoft#31469) chore: use new performant 'type-check' for v9 libaries (microsoft#31454) applying package updates fix(Timepicker-compat): clearIcon not working in freeform (microsoft#31324) chore: re-enable lint rule (microsoft#31459) feat(react-tag-picker): adds text property to TagPickerOption (microsoft#31474) feat(recipes): create package with initial implementation (moved from /apps) (microsoft#31386) applying package updates applying package updates chore: revert globals changes (microsoft#31470) (web-components) Use `ElementInternals` for TextInput elements (microsoft#31201) chore:(docs) Update and migrate component implementation guide (microsoft#31398) disallow all globals in Fluent v9 (microsoft#30967) chore:(react-nav-preview) Recomposing more components and some pixel pushing (microsoft#31387) fix(pr-deploy-site): explicitly set types to not include whole @types/* globals which are causing issues with addition of @types/web (microsoft#31465) fix(recipes-react-components): explicitly set types to not include whole @types/* globals which are cauising issues with addition of @types/web (microsoft#31463) applying package updates applying package updates applying package updates Update IconDirectionContextProvider import to import from specific path (microsoft#31006) ...
...react-drawer/src/components/OverlayDrawer/OverlayDrawerSurface/OverlayDrawerSurface.types.ts
Show resolved
Hide resolved
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beside some small comments,
LGTM ✅.
Would be nice to investigate adding aside
as a possible value to the Dialog
root slot signature instead of casting, we can do that on a follow up PR.
Previous Behavior
Drawer would only allow
<div>
as the root component tagNew Behavior
Drawer now allows
<aside>
tag as well.Related Issue(s)