feat(react-calendar-compat): changed design for the selected state #31509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
📊 Bundle size report
🤖 This report was generated against 52125a2880cfb398e736a9b8d54788a008fe8fe7 |
fabricteam
reviewed
May 29, 2024
change/@fluentui-react-calendar-compat-acdf3646-9c24-46d9-85eb-7f68e84c551d.json
Show resolved
Hide resolved
sopranopillow
previously approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Approving with the following work item pending #31551
Thanks for the changes!
change/@fluentui-react-calendar-compat-acdf3646-9c24-46d9-85eb-7f68e84c551d.json
Show resolved
Hide resolved
sopranopillow
dismissed
their stale review
found some issues that should be addressed
sopranopillow
approved these changes
Jun 3, 2024
...act-components/react-calendar-compat/src/components/CalendarDayGrid/CalendarDayGrid.types.ts
Outdated
Show resolved
Hide resolved
...act-components/react-calendar-compat/src/components/CalendarDayGrid/CalendarDayGrid.types.ts
Outdated
Show resolved
Hide resolved
change/@fluentui-react-calendar-compat-acdf3646-9c24-46d9-85eb-7f68e84c551d.json
Outdated
Show resolved
Hide resolved
...ents/react-calendar-compat/src/components/CalendarDayGrid/useCalendarDayGridStyles.styles.ts
Outdated
Show resolved
Hide resolved
…/CalendarDayGrid/CalendarDayGrid.types.ts Co-authored-by: Esteban Munoz Facusse <estebanmu@microsoft.com>
…/CalendarDayGrid/CalendarDayGrid.types.ts Co-authored-by: Esteban Munoz Facusse <estebanmu@microsoft.com>
…/CalendarDayGrid/useCalendarDayGridStyles.styles.ts Co-authored-by: Esteban Munoz Facusse <estebanmu@microsoft.com>
…-7f68e84c551d.json Co-authored-by: Esteban Munoz Facusse <estebanmu@microsoft.com>
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
…icrosoft#31509) Co-authored-by: Esteban Munoz Facusse <estebanmu@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4pxfor consistency