bugfix(react-tree): ensure roving tab index when children changes #31595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsunderhus
changed the title
YuanboXue-Amber
approved these changes
Jun 6, 2024
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender | 37 | 33 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 79 | 75 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 618 | 638 | 5000 | |
| Button | mount | 289 | 305 | 5000 | |
| Field | mount | 1160 | 1137 | 5000 | |
| FluentProvider | mount | 711 | 718 | 5000 | |
| FluentProviderWithTheme | mount | 80 | 90 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 37 | 33 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 79 | 75 | 10 | Possible regression |
| MakeStyles | mount | 864 | 857 | 50000 | |
| Persona | mount | 1750 | 1716 | 5000 | |
| SpinButton | mount | 1355 | 1419 | 5000 | |
| SwatchPicker | mount | 1558 | 1508 | 5000 |
📊 Bundle size report
Unchanged fixtures
|
fabricteam
reviewed
Jun 6, 2024
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
ling1726
added a commit
to ling1726/fluentui
that referenced
this pull request
Jul 4, 2024
unmounted Follow up from microsoft#31595 The current tree item with tabindex 0 can be unmounted but kept as a reference in side the navigation state. This causes the update to be skipped even when in reality there is no tabbable item. Adds an extra check that the current item is in DOM to fix for this case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
useEffectto ensure that if no element is currently withtabindex=0then the roved element should be recalculated.Related Issue(s)