-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Tree): Roving tabindexes should be refreshed if current element is unmounted #31918
Merged
ling1726
merged 3 commits into
microsoft:master
from
ling1726:react-tree/fix/roving-tabindex-reset
Jul 4, 2024
Merged
fix(Tree): Roving tabindexes should be refreshed if current element is unmounted #31918
ling1726
merged 3 commits into
microsoft:master
from
ling1726:react-tree/fix/roving-tabindex-reset
Jul 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unmounted Follow up from microsoft#31595 The current tree item with tabindex 0 can be unmounted but kept as a reference in side the navigation state. This causes the update to be skipped even when in reality there is no tabbable item. Adds an extra check that the current item is in DOM to fix for this case
ling1726
changed the title
fix(Tree): Roving tabindexes should be refreshed if current element is
fix(Tree): Roving tabindexes should be refreshed if current element is unmounted
Jul 4, 2024
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
FluentProviderWithTheme | mount | 78 | 81 | 10 | Possible regression |
FluentProviderWithTheme | virtual-rerender | 31 | 39 | 10 | Possible regression |
All results
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 636 | 658 | 5000 | |
Button | mount | 290 | 306 | 5000 | |
Field | mount | 1193 | 1132 | 5000 | |
FluentProvider | mount | 727 | 710 | 5000 | |
FluentProviderWithTheme | mount | 78 | 81 | 10 | Possible regression |
FluentProviderWithTheme | virtual-rerender | 31 | 39 | 10 | Possible regression |
FluentProviderWithTheme | virtual-rerender-with-unmount | 84 | 76 | 10 | |
MakeStyles | mount | 870 | 867 | 50000 | |
Persona | mount | 1744 | 1704 | 5000 | |
SpinButton | mount | 1412 | 1369 | 5000 | |
SwatchPicker | mount | 1666 | 1729 | 5000 |
📊 Bundle size report
Unchanged fixtures
|
fabricteam
reviewed
Jul 4, 2024
jurokapsiar
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #31595
The current tree item with tabindex 0 can be unmounted but kept as a reference in side the navigation state. This causes the update to be skipped even when in reality there is no tabbable item.
Adds an extra check that the current item is in DOM to fix for this case and improves the test to handle this case