Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react-calendar-compat): fixed focus indicator cut off #31596

Merged
merged 2 commits into from
Jun 17, 2024
Merged

fix(react-calendar-compat): fixed focus indicator cut off #31596

merged 2 commits into from
Jun 17, 2024

Conversation

ValentinaKozlova
Copy link
Contributor

@ValentinaKozlova ValentinaKozlova commented Jun 6, 2024 •
edited
Loading

Previous Behavior

  • Focus indicator get cut off in Calendar Month selection
    focus-bug

New Behavior

  • Focus should be fully visible
  • Removed TRANSITION_ROW_DISAPPEARANCE animation to improve performance
    focus-fix-

@ValentinaKozlova ValentinaKozlova added the Component: Calendar Compat Calendar Compat component label Jun 6, 2024
@ValentinaKozlova ValentinaKozlova self-assigned this Jun 6, 2024
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Jun 6, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 6, 2024 •
edited
Loading

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-calendar-compat
Calendar Compat		 149.45 kB
39.786 kB		 149.583 kB
39.839 kB		 133 B
53 B
react-datepicker-compat
DatePicker Compat		 222.874 kB
63.098 kB		 223.007 kB
63.137 kB		 133 B
39 B

🤖 This report was generated against 5139ad8299071bb70681a140ce52b12cc24763fc

@ValentinaKozlova ValentinaKozlova marked this pull request as ready for review June 13, 2024 10:17
mainframev
mainframev approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@mainframev mainframev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@ValentinaKozlova ValentinaKozlova merged commit 5b3fcbd into microsoft:master Jun 17, 2024
18 checks passed
@ValentinaKozlova ValentinaKozlova deleted the fix/calendar-compat-focus-state branch June 17, 2024 16:27
@ValentinaKozlova ValentinaKozlova mentioned this pull request Jun 17, 2024
Closed
2 tasks
EdDaWord pushed a commit to EdDaWord/fluentui that referenced this pull request Jun 17, 2024
@ValentinaKozlova @EdDaWord
fix(react-calendar-compat): fixed focus indicator cut off (microsoft#…
236a3ad 
…31596)
EdDaWord pushed a commit to EdDaWord/fluentui that referenced this pull request Aug 14, 2024
@mltejera @EdDaWord
fix:react-nav-preview: High contrast issues (microsoft#31704)
e5ce9d1 
chore(motion): add bundle size fixtures (microsoft#31730)

fix(react-calendar-compat): fixed focus indicator cut off (microsoft#31596)

feat: use custom states for button and anchor button variants (microsoft#31718)

docs: add min-width styles to Table and DataGrid stories, add best practices (microsoft#31721)

fix:react-nav-preview: High contrast issues (microsoft#31704)

Pretty & lint & yarn change

Somehow missed change files

Fix one of the tests

Fix React-text test

Use hashed name for each semantic and control token
EdDaWord pushed a commit to EdDaWord/fluentui that referenced this pull request Aug 14, 2024
@mltejera @EdDaWord
fix:react-nav-preview: High contrast issues (microsoft#31704)
f32f216 
chore(motion): add bundle size fixtures (microsoft#31730)

fix(react-calendar-compat): fixed focus indicator cut off (microsoft#31596)

feat: use custom states for button and anchor button variants (microsoft#31718)

docs: add min-width styles to Table and DataGrid stories, add best practices (microsoft#31721)

fix:react-nav-preview: High contrast issues (microsoft#31704)

Pretty & lint & yarn change

Somehow missed change files

Fix one of the tests

Fix React-text test

Use hashed name for each semantic and control token
EdDaWord pushed a commit to EdDaWord/fluentui that referenced this pull request Aug 16, 2024
@ValentinaKozlova @EdDaWord
fix(react-calendar-compat): fixed focus indicator cut off (microsoft#…
88228c8 
…31596)
EdDaWord added a commit that referenced this pull request Aug 19, 2024
@EdDaWord
Try a single file change
8a89eb6 
Change most tokens in useButtonStyles file

Give all the react-components a try

chore(motion): add bundle size fixtures (#31730)

fix(react-calendar-compat): fixed focus indicator cut off (#31596)

feat: use custom states for button and anchor button variants (#31718)

feat: update badge to use custom states (#31733)

fix: Teaching bubble carousel tabs are visible in windows high contrast (#31734)

fix:react-nav-preview: High contrast issues (#31704)

Pretty & lint & yarn change

Somehow missed change files

Fix one of the tests

Fix React-text test
EdDaWord added a commit that referenced this pull request Aug 19, 2024
@EdDaWord
Try a single file change
537f055 
Change most tokens in useButtonStyles file

Give all the react-components a try

fix: Teaching bubble carousel tabs are visible in windows high contrast (#31734)

fix:react-nav-preview: High contrast issues (#31704)

chore(motion): add bundle size fixtures (#31730)

fix(react-calendar-compat): fixed focus indicator cut off (#31596)

feat: use custom states for button and anchor button variants (#31718)

docs: add min-width styles to Table and DataGrid stories, add best practices (#31721)

fix:react-nav-preview: High contrast issues (#31704)

Pretty & lint & yarn change

Somehow missed change files

Fix one of the tests

Fix React-text test

Use hashed name for each semantic and control token

Build

missed one

Fix small mistake

Fix small mistake

Fix small mistake
EdDaWord added a commit that referenced this pull request Aug 19, 2024
@EdDaWord
Try a single file change
ffdafe1 
Change most tokens in useButtonStyles file

Give all the react-components a try

fix: Teaching bubble carousel tabs are visible in windows high contrast (#31734)

fix:react-nav-preview: High contrast issues (#31704)

chore(motion): add bundle size fixtures (#31730)

fix(react-calendar-compat): fixed focus indicator cut off (#31596)

feat: use custom states for button and anchor button variants (#31718)

docs: add min-width styles to Table and DataGrid stories, add best practices (#31721)

fix:react-nav-preview: High contrast issues (#31704)

Pretty & lint & yarn change

Somehow missed change files

Fix one of the tests

Fix React-text test

Use hashed name for each semantic and control token

Build

missed one

Fix small mistake

Fix small mistake

Fix small mistake

Fix Random YML File
EdDaWord added a commit that referenced this pull request Aug 20, 2024
@EdDaWord
Try a single file change