Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(public-doscite-v9): global styles should not be applied to story elements #32472

Merged
merged 7 commits into from
Sep 10, 2024
Merged

fix(public-doscite-v9): global styles should not be applied to story elements #32472

merged 7 commits into from
Sep 10, 2024

Conversation

dmytrokirpa
Copy link
Contributor

Previous Behavior

The global styles of Storybook for specific native elements have unintentionally impacted the stories.

New Behavior

Refine global CSS selectors for elements to enhance specificity and prevent style leakage into stories.

Related Issue(s)

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 5, 2024 •
edited
Loading

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 5, 2024 •
edited
Loading

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 5, 2024 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 638 622 5000
Breadcrumb mount 1698 1653 1000
Checkbox mount 1716 1679 5000
CheckboxBase mount 1482 1510 5000
ChoiceGroup mount 3009 3061 5000
ComboBox mount 666 673 1000
CommandBar mount 6592 6528 1000
ContextualMenu mount 12110 12174 1000
DefaultButton mount 795 799 5000
DetailsRow mount 2236 2234 5000
DetailsRowFast mount 2298 2216 5000
DetailsRowNoStyles mount 2113 2101 5000
Dialog mount 2647 2699 1000
DocumentCardTitle mount 227 223 1000
Dropdown mount 1987 1998 5000
FocusTrapZone mount 1096 1204 5000
FocusZone mount 1090 1102 5000
GroupedList mount 42559 42324 2
GroupedList virtual-rerender 20276 20354 2
GroupedList virtual-rerender-with-unmount 51707 51776 2
GroupedListV2 mount 228 229 2
GroupedListV2 virtual-rerender 225 216 2
GroupedListV2 virtual-rerender-with-unmount 230 225 2
IconButton mount 1136 1117 5000
Label mount 341 346 5000
Layer mount 2787 2786 5000
Link mount 403 405 5000
MenuButton mount 1007 985 5000
MessageBar mount 21298 21523 5000
Nav mount 2042 2094 1000
OverflowSet mount 800 799 5000
Panel mount 1870 1860 1000
Persona mount 764 735 1000
Pivot mount 901 909 1000
PrimaryButton mount 953 938 5000
Rating mount 4733 4704 5000
SearchBox mount 923 939 5000
Shimmer mount 1914 1946 5000
Slider mount 1350 1332 5000
SpinButton mount 2971 3007 5000
Spinner mount 386 407 5000
SplitButton mount 1875 1922 5000
Stack mount 429 419 5000
StackWithIntrinsicChildren mount 863 880 5000
StackWithTextChildren mount 2798 2811 5000
SwatchColorPicker mount 6510 6438 5000
TagPicker mount 1465 1491 5000
Text mount 390 383 5000
TextField mount 945 918 5000
ThemeProvider mount 858 873 5000
ThemeProvider virtual-rerender 594 574 5000
ThemeProvider virtual-rerender-with-unmount 1304 1328 5000
Toggle mount 618 592 5000
buttonNative mount 183 201 5000

@dmytrokirpa dmytrokirpa self-assigned this Sep 6, 2024
@dmytrokirpa dmytrokirpa marked this pull request as ready for review September 6, 2024 05:59
@dmytrokirpa dmytrokirpa requested a review from a team as a code owner September 6, 2024 05:59
@fabricteam
Copy link
Collaborator

fabricteam commented Sep 8, 2024 •
edited
Loading

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

@dmytrokirpa dmytrokirpa merged commit e98c6f0 into microsoft:master Sep 10, 2024
19 checks passed
@dmytrokirpa dmytrokirpa deleted the fix/storybook-global-styles branch September 10, 2024 13:13
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Sep 12, 2024
@marcosmoura
Merge branch 'master' into feat/tokens/add-zindexes
861193e 
* master: (77 commits)
  fix(react-drawer): update scroll state when children changes (microsoft#32818)
  feat(react-storybook-addon): improve addon to more readable names (microsoft#32815)
  chore: cleanup react-carousel-preview (microsoft#32475)
  feat(storybook): add rtl/ltr toggle storybook addon (microsoft#32814)
  Carousel: Storybook updates and fixing exports/focus (microsoft#32457)
  release: applying package updates - react v8
  release: applying package updates - web-components
  Update d3 dependency versions to 3.x.x and 4.x.x (microsoft#32463)
  RFC: Extended Design Tokens for Fluent UI React (microsoft#32058)
  update doc to reflect setTheme function change (microsoft#32490)
  fix (react-dialog): Use consistent rounding for clientHeight and innerHeight (microsoft#32480)
  fix(public-doscite-v9): global styles should not be applied to story elements (microsoft#32472)
  feat(workspace-plugin): implement verify-packaging executor (microsoft#32403)
  release: applying package updates - react-components
  Add strokeDasharray property when optimizeLargeData is true (microsoft#32494)
  fix(TreeItemLayout): Actions should not unmount between successive mouse events (microsoft#32477)
  release: applying package updates - react v8
  bugfix(react-tree): recover from tabIndex=-1 when TreeItem is removed (microsoft#32442)
  Fix onResolveSuggestions not being called after component is remounted in react 18 strict mode (microsoft#28227)
  fix(codeowners): update most packages owned by cxe-red with cxe-prg (microsoft#32445)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

@marcosmoura marcosmoura marcosmoura approved these changes

@Hotell Hotell Hotell approved these changes

Assignees

@dmytrokirpa dmytrokirpa

Labels
Area: Documentation Type: Bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Global Storybook styles are being applied to story elements
4 participants
@dmytrokirpa @fabricteam @Hotell @marcosmoura