Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup react-carousel-preview #32475

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Sep 6, 2024

New Behavior

  • Removes unused CarouselFooter
  • Adds tests for CarouselAutoplayButton
  • Refactors CarouselNav to have a separate CarouselNavIndexContextProvider to avoid perf issues
  • Renames enableDrag prop to draggable to match our naming patterns

Related Issue(s)

  • Fixes #

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 6, 2024

📊 Bundle size report

✅ No changes found

@layershifter layershifter force-pushed the chore/carousel-cleaning branch 3 times, most recently from ded9f8c to 15e640b Compare September 6, 2024 15:15
@layershifter layershifter marked this pull request as ready for review September 6, 2024 15:45
Copy link
Contributor

@Mitch-At-Work Mitch-At-Work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these might conflict with our current bug bash updates, but should be fine to resolve as they align

Copy link
Contributor

@Hotell Hotell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for v-build affected files

@layershifter layershifter merged commit 609b363 into microsoft:master Sep 11, 2024
18 checks passed
@layershifter layershifter deleted the chore/carousel-cleaning branch September 11, 2024 10:45
@gouttierre gouttierre mentioned this pull request Sep 11, 2024
28 tasks
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Sep 12, 2024
* master: (77 commits)
  fix(react-drawer): update scroll state when children changes (microsoft#32818)
  feat(react-storybook-addon): improve addon to more readable names (microsoft#32815)
  chore: cleanup react-carousel-preview (microsoft#32475)
  feat(storybook): add rtl/ltr toggle storybook addon (microsoft#32814)
  Carousel: Storybook updates and fixing exports/focus (microsoft#32457)
  release: applying package updates - react v8
  release: applying package updates - web-components
  Update d3 dependency versions to 3.x.x and 4.x.x (microsoft#32463)
  RFC: Extended Design Tokens for Fluent UI React (microsoft#32058)
  update doc to reflect setTheme function change (microsoft#32490)
  fix (react-dialog): Use consistent rounding for clientHeight and innerHeight (microsoft#32480)
  fix(public-doscite-v9): global styles should not be applied to story elements (microsoft#32472)
  feat(workspace-plugin): implement verify-packaging executor (microsoft#32403)
  release: applying package updates - react-components
  Add strokeDasharray property when optimizeLargeData is true (microsoft#32494)
  fix(TreeItemLayout): Actions should not unmount between successive mouse events (microsoft#32477)
  release: applying package updates - react v8
  bugfix(react-tree): recover from tabIndex=-1 when TreeItem is removed (microsoft#32442)
  Fix onResolveSuggestions not being called after component is remounted in react 18 strict mode (microsoft#28227)
  fix(codeowners): update most packages owned by cxe-red with cxe-prg (microsoft#32445)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants