ACL with Microsoft Entra token support #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Currently ACL auth by default does username and password validation with ACL entries. We compose it with an IAuthenticator instance to inject authentication behavior of username and password and then just validate the permissions against the ACL list of the user. This approach is more favorable as it minimizes changes and avoids redundant code needed to combine behaviors of AclAuthenticator and AADAuthenticator. Rather than inheriting these behavior, we compose AclAuthenticator with an IAuthenticator. Testing: There were no AAD tests. Have added a basic test to validate AAD + ACL and that it works with cluster auth.
vazois
requested changes
May 13, 2024
vazois
requested changes
May 14, 2024
- Refactor to AclWithAad and AclWithPassword hierarchies - fix naming convention for private member _validateUsername - add comments and fix tests
- Add support for groupId check and corresponding test
vazois
requested changes
May 17, 2024
… and move test constructor for IssuerSigningTokenProvider to test code
chyin6
pushed a commit
to jusjin-org/garnet
that referenced
this pull request
Jul 2, 2024
* - Added option to allow AAD auth with ACL - Currently ACL auth by default does username and password validation with ACL entries. We compose it with an IAuthenticator instance to inject authentication behavior of username and password and then just validate the permissions against the ACL list of the user. This approach is more favorable as it minimizes changes and avoids redundant code needed to combine behaviors of AclAuthenticator and AADAuthenticator. Rather than inheriting these behavior, we compose AclAuthenticator with an IAuthenticator. Testing: There were no AAD tests. Have added a basic test to validate AAD + ACL and that it works with cluster auth. * formatting fixes * - Added AADValidateUsername flag - Refactor to AclWithAad and AclWithPassword hierarchies - fix naming convention for private member _validateUsername - add comments and fix tests * fomratting fixes * fix logger parameter positioning * fix parameter ordering for logger * add default value * add base type assertions * add default value - failing test due to this. * - Fix comments to account for groupId - Add support for groupId check and corresponding test * Refactor code to separeate Authentication settings into seprate files and move test constructor for IssuerSigningTokenProvider to test code --------- Co-authored-by: Lukas Maas <lumaas@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes changes for #377.
The changes are done
Testing:
There were no AAD tests. Have added a basic test to validate AAD + ACL and that it works with cluster auth.
I had to add support for a new constructor for testing with IssuerSigningToken - it might be easier to put this behind an abstraction but didn't do it to avoid changing scope of this PR