Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACL with Microsoft Entra token support #378

Merged
merged 14 commits into from
May 21, 2024

Commits on May 12, 2024

  1. - Added option to allow AAD auth with ACL

    - Currently ACL auth by default does username and password validation with ACL entries. We compose it with an IAuthenticator instance to inject authentication behavior of username and  password and then just validate the permissions against the ACL list of the user. This approach is more favorable as it minimizes changes and avoids redundant code needed to combine behaviors of AclAuthenticator and AADAuthenticator. Rather than inheriting these behavior, we compose AclAuthenticator with an IAuthenticator.
    
    Testing:
    There were no AAD tests. Have added a basic test to validate AAD + ACL and that it works with cluster auth.
    msft-paddy14 committed May 12, 2024
    Configuration menu
    Copy the full SHA
    e471d9e View commit details
    Browse the repository at this point in the history
  2. resolve merge conflilct

    msft-paddy14 committed May 12, 2024
    Configuration menu
    Copy the full SHA
    e8aa748 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. formatting fixes

    msft-paddy14 committed May 13, 2024
    Configuration menu
    Copy the full SHA
    1accb31 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Configuration menu
    Copy the full SHA
    0870447 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. - Added AADValidateUsername flag

    - Refactor to AclWithAad and AclWithPassword hierarchies
    - fix naming convention for private member _validateUsername
    - add comments and fix tests
    msft-paddy14 committed May 15, 2024
    Configuration menu
    Copy the full SHA
    63713d3 View commit details
    Browse the repository at this point in the history
  2. fomratting fixes

    msft-paddy14 committed May 15, 2024
    Configuration menu
    Copy the full SHA
    1375716 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    14602bc View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    24d129b View commit details
    Browse the repository at this point in the history
  5. add default value

    msft-paddy14 committed May 15, 2024
    Configuration menu
    Copy the full SHA
    d074d23 View commit details
    Browse the repository at this point in the history
  6. add base type assertions

    msft-paddy14 committed May 15, 2024
    Configuration menu
    Copy the full SHA
    91ad7b6 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Configuration menu
    Copy the full SHA
    42a237a View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. - Fix comments to account for groupId

    - Add support for groupId check and corresponding test
    msft-paddy14 committed May 17, 2024
    Configuration menu
    Copy the full SHA
    7997290 View commit details
    Browse the repository at this point in the history
  2. Refactor code to separeate Authentication settings into seprate files…

    … and move test constructor for IssuerSigningTokenProvider to test code
    msft-paddy14 committed May 17, 2024
    Configuration menu
    Copy the full SHA
    5496725 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Configuration menu
    Copy the full SHA
    42a2f2b View commit details
    Browse the repository at this point in the history