-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACL with Microsoft Entra token support #378
Merged
Merged
Commits on May 12, 2024
-
- Added option to allow AAD auth with ACL
- Currently ACL auth by default does username and password validation with ACL entries. We compose it with an IAuthenticator instance to inject authentication behavior of username and password and then just validate the permissions against the ACL list of the user. This approach is more favorable as it minimizes changes and avoids redundant code needed to combine behaviors of AclAuthenticator and AADAuthenticator. Rather than inheriting these behavior, we compose AclAuthenticator with an IAuthenticator. Testing: There were no AAD tests. Have added a basic test to validate AAD + ACL and that it works with cluster auth.
Configuration menu - View commit details
-
Copy full SHA for e471d9e - Browse repository at this point
Copy the full SHA e471d9eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e8aa748 - Browse repository at this point
Copy the full SHA e8aa748View commit details
Commits on May 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1accb31 - Browse repository at this point
Copy the full SHA 1accb31View commit details
Commits on May 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0870447 - Browse repository at this point
Copy the full SHA 0870447View commit details
Commits on May 15, 2024
-
- Added AADValidateUsername flag
- Refactor to AclWithAad and AclWithPassword hierarchies - fix naming convention for private member _validateUsername - add comments and fix tests
Configuration menu - View commit details
-
Copy full SHA for 63713d3 - Browse repository at this point
Copy the full SHA 63713d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1375716 - Browse repository at this point
Copy the full SHA 1375716View commit details -
Configuration menu - View commit details
-
Copy full SHA for 14602bc - Browse repository at this point
Copy the full SHA 14602bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 24d129b - Browse repository at this point
Copy the full SHA 24d129bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d074d23 - Browse repository at this point
Copy the full SHA d074d23View commit details -
Configuration menu - View commit details
-
Copy full SHA for 91ad7b6 - Browse repository at this point
Copy the full SHA 91ad7b6View commit details
Commits on May 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 42a237a - Browse repository at this point
Copy the full SHA 42a237aView commit details
Commits on May 17, 2024
-
- Fix comments to account for groupId
- Add support for groupId check and corresponding test
Configuration menu - View commit details
-
Copy full SHA for 7997290 - Browse repository at this point
Copy the full SHA 7997290View commit details -
Refactor code to separeate Authentication settings into seprate files…
… and move test constructor for IssuerSigningTokenProvider to test code
Configuration menu - View commit details
-
Copy full SHA for 5496725 - Browse repository at this point
Copy the full SHA 5496725View commit details
Commits on May 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 42a2f2b - Browse repository at this point
Copy the full SHA 42a2f2bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.