Use wingetcreate to publish Windows releases

[ldennington]

Remove custom mjcheetham/update-winget task in favor of using the wingetcreate tool.

See a preview of what the new manifests minted by wingetcreate will look like here. Note however that I have submitted some modifications here both for correctness and compatibility with wingetcreate.

[dscho]

To make the next rebase to a new Git for Windows version easier, could this commit be marked up as a fixup! commit?

[ldennington]

To make the next rebase to a new Git for Windows version easier, could this commit be marked up as a fixup! commit?

Ah yes my apologies for forgetting. When I run git blame I see that parts of the file were changed with different commits. In this scenario, do I run git commit --fixup against the earlier of the 2 commits?

[dscho]

To make the next rebase to a new Git for Windows version easier, could this commit be marked up as a fixup! commit?

Ah yes my apologies for forgetting. When I run git blame I see that parts of the file were changed with different commits. In this scenario, do I run git commit --fixup against the earlier of the 2 commits?

Yes, I would split the commit into two fixup!s. At least that's what I usually would do.

In this instance, it looks as if the release-winget.yml file was touched by 2b74bbb, 88c6b40 and c9c8d9e. In the tentative rebase to v2.34.0-rc0, we squashed all of the updates back into the commit that creates that file: c81cf35. So maybe just do git commit --fixup c81cf3508b12d55fb76ed469199db52785a93452 --amend (since it does not use the actual hash, but the oneline instead, it does not really matter whether you use c81cf35 or 2b74bbb)?

[derrickstolee]

The Scalar Functional tests are failing because I changed microsoft/scalar to work with v2.34.0. We will want to take this change into the vfs-2.34.0 branch when its ready. We could even force-merge it here and take it in the tentative/vfs-2.34.0 branch when you're done, @ldennington.

[ldennington]

The Scalar Functional tests are failing because I changed microsoft/scalar to work with v2.34.0. We will want to take this change into the vfs-2.34.0 branch when its ready. We could even force-merge it here and take it in the tentative/vfs-2.34.0 branch when you're done, @ldennington.

Sounds good. I'll have to work the issues on the wingetcreate side before merging. Planning for that to be my focus today.

[dscho]

Neat!

[ldennington]

Good news!! The wingetcreate folks have already merged the needed fix on their end. We should be good to merge this as soon as their next release is live 😊😊😊. I'll go ahead and do the fixups before I finish up for the day, though, to make sure I don't forget.

@derrickstolee What do you think would be the best way to ensure this makes it into vfs-2.34.0?

[derrickstolee]

@derrickstolee What do you think would be the best way to ensure this makes it into vfs-2.34.0?

@ldennington merge this and I will rebase it (and its merge commit) onto the tentative/vfs-2.34.0 branch.

[dscho]

rebase it (and its merge commit)

Or maybe just squash it into the commit that introduces .github/workflows/release-winget.yml?

[derrickstolee]

rebase it (and its merge commit)

Or maybe just squash it into the commit that introduces .github/workflows/release-winget.yml?

well, that would happen in the next rebase, which will happen before the release.

[ldennington]

Re-opening following corrected rebase