Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Microsoft Git metadata #32219

Merged
1 commit merged into from
Nov 5, 2021
Merged

Update Microsoft Git metadata #32219

1 commit merged into from
Nov 5, 2021

Conversation

ldennington
Copy link
Contributor

@ldennington ldennington commented Oct 26, 2021 •
edited by ghost
Loading

The Git Fundamentals team is in the process of switching to wingetcreate to
publish its tools to microsoft/winget-pkgs. During this effort, we noticed
fields in the latest manifest that need to be modified both for correctness
and compatibility with wingetcreate.

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema? Note: This will become a multi-file manifest in the next release using wingetcreate.

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Internal-Error-Static-Scan The test that runs static analysis failed. label Oct 26, 2021
@ghost
Copy link

ghost commented Oct 26, 2021

Hello @ldennington,
The pull request encountered an internal error and has been assigned to a developer to investigate.

@ghost ghost added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Oct 26, 2021
@ghost ghost assigned ranm-msft Oct 26, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost ghost removed Internal-Error-Static-Scan The test that runs static analysis failed. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Oct 26, 2021
@wingetbot wingetbot added the Internal-Error-Static-Scan The test that runs static analysis failed. label Oct 26, 2021
@ghost
Copy link

ghost commented Oct 26, 2021

Hello @ldennington,
The pull request encountered an internal error and has been assigned to a developer to investigate.

@ghost ghost added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Oct 26, 2021
@ghost ghost assigned ranm-msft Oct 26, 2021
ItzLevvie
ItzLevvie previously approved these changes Oct 26, 2021
View reviewed changes
@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Oct 26, 2021
@ldennington ldennington mentioned this pull request Oct 26, 2021
Merged
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost ghost removed Internal-Error-Static-Scan The test that runs static analysis failed. Needs-Attention This work item needs to be reviewed by a member of the core team. Moderator-Approved One of the Moderators has reviewed and approved this PR labels Oct 26, 2021
@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Oct 26, 2021
@ghost ghost assigned ldennington Oct 26, 2021
@ghost
Copy link

ghost commented Oct 26, 2021

Hello @ldennington,
During installation testing, this application failed to install without user input. Did you forget to add Silent or SilentWithProgress switches?

This can also happen when a dependency is missing. You can test with https://github.com/microsoft/winget-pkgs#test-your-manifest.

Please investigate a fix and resubmit the Pull Request.

You may also try using the Windows Package Manager Manifest Creator to determine the proper installer type. If the installer type is MSIX, MSI or a known installer technology like NullSoft, Inno, etc. the wingetcreate tool can detect then the winget client will know what switches to pass. If it's a .exe installer of an unknown type, you will need to search to determine the proper switches for Silent and SilentWithProgress.

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Oct 26, 2021
@ghost ghost removed Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. labels Nov 1, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Nov 1, 2021
@ghost
Copy link

ghost commented Nov 1, 2021

Hello @ldennington,
During installation testing, this application failed to install without user input. Did you forget to add Silent or SilentWithProgress switches?

This can also happen when a dependency is missing. You can test with https://github.com/microsoft/winget-pkgs#test-your-manifest.

Please investigate a fix and resubmit the Pull Request.

You may also try using the Windows Package Manager Manifest Creator to determine the proper installer type. If the installer type is MSIX, MSI or a known installer technology like NullSoft, Inno, etc. the wingetcreate tool can detect then the winget client will know what switches to pass. If it's a .exe installer of an unknown type, you will need to search to determine the proper switches for Silent and SilentWithProgress.

@ghost ghost added Needs-Author-Feedback This needs a response from the author. Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Nov 1, 2021
ItzLevvie
ItzLevvie suggested changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@ItzLevvie ItzLevvie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#32219 (comment)

@ghost ghost added Needs-Author-Feedback This needs a response from the author. and removed Needs-Author-Feedback This needs a response from the author. Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. labels Nov 3, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ldennington
Update Microsoft Git metadata
c0e6bbe 
The Git Fundamentals team is in the process of switching to wingetcreate to
publish its tools to microsoft/winget-pkgs. During this effort, we noticed
fields in the latest manifest that need to be modified both for correctness
and compatibility with wingetcreate.
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Nov 4, 2021
@ghost
Copy link

ghost commented Nov 4, 2021

Hello @wingetbot!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Nov 5, 2021
@ghost
Copy link

ghost commented Nov 5, 2021

Hello @ldennington,
Validation has completed.

@ghost ghost merged commit 1ffa88e into microsoft:master Nov 5, 2021
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@ldennington ldennington deleted the update-microsoft-git-metadata branch July 18, 2022 18:07
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItzLevvie ItzLevvie ItzLevvie approved these changes

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ldennington @wingetbot @ItzLevvie @ranm-msft