-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Choco package for v1.3.0 #451
Conversation
@@ -3,7 +3,7 @@ | |||
<package xmlns="http://schemas.microsoft.com/packaging/2015/06/nuspec.xsd"> | |||
<metadata> | |||
<id>sqlcmd</id> | |||
<version>0.8.1</version> | |||
<version>1.3.0</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package script doesn't generate this file. Should we be generating this file as part of package script?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, the file can reference the version as a variable, and the pack command that generates the package from the nuspec can set the variable
@@ -2,7 +2,7 @@ | |||
|
|||
$toolsDir = "$(Split-Path -parent $MyInvocation.MyCommand.Definition)" | |||
$url = '{{DownloadUrl}}' | |||
$url64 = 'https://download.microsoft.com/download/d/4/4/d4403a51-2ab7-4ea8-b850-d2710c5e1323/sqlcmd_0.8.1-1.msi' | |||
$url64 = 'https://github.com/microsoft/go-sqlcmd/releases/download/v1.3.0/sqlcmd-x64_1.3.0-1.msi' | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changing from the downloads site to github seems like a big deal. Do you know why we were using downloads before, and if there's any approval needed to stop using it?
And what is the value of $url
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the download site for the previous version here and noticed that it is pointing to github. Thought of updating the files in our repo first to keep them in sync with choco. The choco command to push the package doesn't really rely on these files.
File an issue to change how these files are generated. We should just have a template in the repo, and the official build should create the package by populating the template with the actual tag value and github locations and checksum. |
we shouldn't add nupkg files to the repo |
Updating files required to prepare a choco package.
Tested as below
Updated sqlcmd.nuspec and tools\chocolateyinstall and ran
choco pack sqlcmd.nuspec
Tested as per instructions here
No issues seen.