Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Choco package for v1.3.0 #451

Closed
wants to merge 3 commits into from
Closed

Choco package for v1.3.0 #451

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f2c6f2
Choco package for v1.3.0
apoorvdeshmukh Aug 16, 2023
7fd36b8
Update nupkg and install script
apoorvdeshmukh Aug 16, 2023
c007553
Remove nupkg
apoorvdeshmukh Aug 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions release/windows/choco/sqlcmd.nuspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<package xmlns="http://schemas.microsoft.com/packaging/2015/06/nuspec.xsd">
<metadata>
<id>sqlcmd</id>
<version>0.8.1</version>
<version>1.3.0</version>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.3.0

can we have the pack script set the version from the tag instead of hard coding it here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package script doesn't generate this file. Should we be generating this file as part of package script?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, the file can reference the version as a variable, and the pack command that generates the package from the nuspec can set the variable

<title>sqlcmd (Install)</title>
<authors>Microsoft</authors>
<projectUrl>https://docs.microsoft.com/sql/tools/go-sqlcmd-utility</projectUrl>
Expand All @@ -18,7 +18,7 @@
<tags>sqlcmd mssql sqlserver</tags>
<summary>sqlcmd CLI for Microsoft SQL Server and Azure SQL</summary>
<description>sqlcmd is a multi-platform command line experience for Microsoft SQL Server and Azure SQL</description>
<releaseNotes>https://github.com/microsoft/go-sqlcmd/releases/tag/v0.8.1</releaseNotes>
<releaseNotes>https://github.com/microsoft/go-sqlcmd/releases/tag/v1.3.0</releaseNotes>
</metadata>
<files>
<file src="tools\**" target="tools" />
Expand Down
4 changes: 2 additions & 2 deletions release/windows/choco/tools/VERIFICATION.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ Verification is intended to assist the Chocolatey moderators and community
in verifying that this package's contents are trustworthy.

Download .msi from Microsoft Download Center
https://download.microsoft.com/download/d/4/4/d4403a51-2ab7-4ea8-b850-d2710c5e1323/sqlcmd_0.8.1-1.msi
https://github.com/microsoft/go-sqlcmd/releases/download/v1.3.0/sqlcmd-x64_1.3.0-1.msi

Run checksum -t sha256 -f sqlcmd_0.8.1-1.msi
Run checksum -t sha256 -f sqlcmd-x64_1.3.0-1.msi

We are the software vendor (Microsoft)
7 changes: 2 additions & 5 deletions release/windows/choco/tools/chocolateyinstall.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

$toolsDir = "$(Split-Path -parent $MyInvocation.MyCommand.Definition)"
$url = '{{DownloadUrl}}'
$url64 = 'https://download.microsoft.com/download/d/4/4/d4403a51-2ab7-4ea8-b850-d2710c5e1323/sqlcmd_0.8.1-1.msi'
$url64 = 'https://github.com/microsoft/go-sqlcmd/releases/download/v1.3.0/sqlcmd-x64_1.3.0-1.msi'

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing from the downloads site to github seems like a big deal. Do you know why we were using downloads before, and if there's any approval needed to stop using it?

And what is the value of $url here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the download site for the previous version here and noticed that it is pointing to github. Thought of updating the files in our repo first to keep them in sync with choco. The choco command to push the package doesn't really rely on these files.

$packageArgs = @{
packageName = $env:ChocolateyPackageName
Expand All @@ -15,7 +15,7 @@ $packageArgs = @{

checksum = '{{Checksum}}'
checksumType = '{{ChecksumType}}'
checksum64 = '03587762932D5A66ACFE15D306FE14645D53BC61162B4DA0D9AF29B4A8A1550D'
checksum64 = '7ecae5c7c20c0cb0e44e1b6e5e3a2c2064a4b6fc2bda07622e33aae6d60fd83e'
checksumType64= 'sha256'

silentArgs = "/qn /norestart /l*v `"$($env:TEMP)\$($packageName).$($env:chocolateyPackageVersion).MsiInstall.log`""
Expand All @@ -30,9 +30,6 @@ Install-ChocolateyPackage @packageArgs









Expand Down
Loading