Merge upstream release-branch.go1.17 into microsoft/release-branch.go1.17
#184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Idc207e34c54b9bff0ae59348e4bc97474b1c11d2 Reviewed-on: https://go-review.googlesource.com/c/go/+/334254 Run-TryBot: Cherry Mui <cherryyz@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Go Bot <gobot@golang.org> Trust: Cherry Mui <cherryyz@google.com>
The initial "branch: master" configuration was inherited from when the release-branch.go1.17 branch was branched off the master branch. Update the "branch" key, otherwise a modern git-codereview will mail CLs to the wrong branch. We can set "parent-branch" so that 'git codereview sync-branch' works to merge latest master into release-branch.go1.17, something we want to do for subsequent RCs, maybe up to the final release. (At some point the release freeze will end and tree will open for Go 1.18 development, so we'll be switching to using cherry-picks only. Having parent-branch will not be useful then, but I think harmless.) Change-Id: I36ab977eaeb52bc0a84cc59e807572054f54c789 Reviewed-on: https://go-review.googlesource.com/c/go/+/334376 Reviewed-by: Cherry Mui <cherryyz@google.com> Reviewed-by: Heschi Kreinick <heschi@google.com> Trust: Dmitri Shuralyov <dmitshur@golang.org>
…ch.go1.17 Merge List: + 2021-07-31 b8ca6e5 all: gofmt + 2021-07-30 b7a85e0 net/http/httputil: close incoming ReverseProxy request body + 2021-07-29 70fd4e4 runtime: avoid possible preemption when returning from Go to C + 2021-07-28 9eee0ed cmd/go: fix go.mod file name printed in error messages for replacements + 2021-07-28 b39e0f4 runtime: don't crash on nil pointers in checkptrAlignment + 2021-07-27 7cd10c1 cmd/go: use .mod instead of .zip to determine if version has go.mod file + 2021-07-27 c8cf0f7 cmd/go: add missing flag in UsageLine + 2021-07-27 7ba8e79 testing: clarify T.Name returns a distinct name of the running test + 2021-07-27 33ff155 go/types: preserve untyped constants on the RHS of a shift expression + 2021-07-26 840e583 runtime: correct variable name in comment + 2021-07-26 bfbb288 runtime: remove adjustTimers counter + 2021-07-26 9c81fd5 cmd/vet: add missing copyright header + 2021-07-26 ecaa681 doc: clarify non-nil zero length slice to array pointer conversion + 2021-07-26 1868f82 crypto/x509: update iOS bundled roots to version 55188.120.1.0.1 + 2021-07-25 849b791 spec: use consistent capitalization for rune literal hex constants + 2021-07-23 0914646 doc/1.17: fix two dead rfc links + 2021-07-22 052da57 cmd/compile: do not change field offset in ABI analysis + 2021-07-22 798ec73 runtime: don't clear timerModifiedEarliest if adjustTimers is 0 + 2021-07-22 fdb45ac runtime: move mem profile sampling into m-acquired section + 2021-07-21 3e48c03 reflect: add missing copyright header + 2021-07-21 48c88f1 reflect: add Value.CanConvert + 2021-07-20 9e26569 cmd/go: don't add C compiler ID to hash for standard library + 2021-07-20 d568e6e runtime/debug: skip TestPanicOnFault on netbsd/arm + 2021-07-19 c8f4e61 spec: correct example comment in Conversions from slice to array + 2021-07-19 1d91551 time: correct typo in documentation for UnixMicro + 2021-07-19 404127c cmd/compile: fix off-by-one error in traceback argument counting + 2021-07-19 6298cfe cmd/compile: fix typo in fatal message of builtinCall + 2021-07-19 49402be cmd/{compile,link}: fix bug in map.zero handling + 2021-07-18 a66190e test/bench/go1: fix size for RegexpMatchMedium_32 + 2021-07-18 650fc21 text/scanner: use Go convention in Position doc comment + 2021-07-16 aa4e0f5 net/http: correct capitalization in cancelTimeBody comment + 2021-07-15 0941dbc testing: clarify in docs that TestMain is advanced + 2021-07-15 69728ea cmd/go: update error messages in tests to match CL 332573 + 2021-07-15 c1cc9f9 cmd/compile: fix lookup package of redeclared dot import symbol + 2021-07-15 21a04e3 doc/go1.17: mention GOARCH=loong64 + 2021-07-14 2b00a54 go/build, runtime/internal/sys: reserve GOARCH=loong64 + 2021-07-14 60ddf42 cmd/go: change link in error message from /wiki to /doc. + 2021-07-13 d8f348a cmd/go: remove a duplicated word from 'go help mod graph' Change-Id: I63a540ba823bcbde7249348999ac5a7d9908b531
Change-Id: I1f1ada15d7365db3e48599fbaddd6a65a8e5d06c Reviewed-on: https://go-review.googlesource.com/c/go/+/339130 Run-TryBot: Alexander Rakoczy <alex@golang.org> TryBot-Result: Go Bot <gobot@golang.org> Trust: Alexander Rakoczy <alex@golang.org> Reviewed-by: David Chase <drchase@google.com>
For #22446 Change-Id: I71a30761a28e81c50b7089d5a28be99c736c2dc8 Reviewed-on: https://go-review.googlesource.com/c/go/+/341332 Trust: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com> TryBot-Result: Go Bot <gobot@golang.org>
This flag is undocumented and is no longer useful. Users who want to install additional toolchains without cleaning the installed packages should just use `go install`. This CL changes cmd/dist to print a warning that --no-clean is deprecated and to advise users to use `go install std cmd` instead, and then otherwise ignores it: ``` $ ./make.bash --no-clean Building Go cmd/dist using $GOROOT_BOOTSTRAP. (devel +b7a85e0003 linux/amd64) warning: --no-clean is deprecated and has no effect; use 'go install std cmd' instead Building Go toolchain1 using $GOROOT_BOOTSTRAP. ``` Fixes #47204. Change-Id: I275031832098401a49e491e324e8de3427973630 Reviewed-on: https://go-review.googlesource.com/c/go/+/341392 Trust: Matthew Dempsky <mdempsky@google.com> Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
This failure was confirmed to be due to a bug in prerelease versions of Windows, and has been fixed by now. Remove the skip for this test. Fixes #44379. Change-Id: Idfb92ffd6b9d416d4c78ef3800a5ffdda06c6562 Reviewed-on: https://go-review.googlesource.com/c/go/+/341455 Trust: Dmitri Shuralyov <dmitshur@golang.org> Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Cherry Mui <cherryyz@google.com>
This update was created using the updatecontrib command: go get golang.org/x/build/cmd/updatecontrib cd gotip GO111MODULE=off updatecontrib With manual changes based on publicly available information to canonicalize letter case and formatting for a few names. For #12042. Change-Id: I96718c0fe438cd97b62499a027252748a1fa0779 Reviewed-on: https://go-review.googlesource.com/c/go/+/341709 Trust: Carlos Amedee <carlos@golang.org> Run-TryBot: Carlos Amedee <carlos@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Go Bot <gobot@golang.org>
Fixes #44513. Change-Id: I82c44a681b1fa67df123af86ee02a980b13acdc8 Reviewed-on: https://go-review.googlesource.com/c/go/+/341673 Trust: Dmitri Shuralyov <dmitshur@golang.org> Trust: Carlos Amedee <carlos@golang.org> Reviewed-by: Carlos Amedee <carlos@golang.org> Run-TryBot: Carlos Amedee <carlos@golang.org> TryBot-Result: Go Bot <gobot@golang.org>
…ch.go1.17 Merge List: + 2021-08-12 5805efc doc/go1.17: remove draft notice + 2021-08-12 39634e7 CONTRIBUTORS: update for the Go 1.17 release + 2021-08-12 095bb79 os/exec: re-enable LookPathTest/16 + 2021-08-11 dea23e9 src/make.*: make --no-clean flag a no-op that prints a warning + 2021-08-11 d4c0ed2 doc/go1.17: linker passes -I to extld as -Wl,--dynamic-linker + 2021-08-10 1f9c9d8 doc: use "high address/low address" instead of "top/bottom" + 2021-08-09 f1dce31 cmd/go: with -mod=vendor, don't panic if there are duplicate requirements + 2021-08-09 7aeaad5 runtime/cgo: when using msan explicitly unpoison cgoCallers + 2021-08-08 507cc34 doc: add example for conversion from slice expressions to array ptr + 2021-08-07 891547e doc/go1.17: fix a typo introduced in CL 335135 + 2021-08-06 8eaf4d1 make.bash: do not overwrite GO_LDSO if already set + 2021-08-06 63b968f doc/go1.17: clarify Modules changes + 2021-08-06 70546f6 runtime: allow arm64 SEH to be called if illegal instruction + 2021-08-05 fd45e26 runtime: warn that KeepAlive is not an unsafe.Pointer workaround + 2021-08-04 6e73886 net/http: speed up and deflake TestCancelRequestWhenSharingConnection + 2021-08-02 8a7ee4c io/fs: don't use absolute path in DirEntry.Name doc Change-Id: Ie9ce48bf4e99457cde966c5f972b04140468fcf0
The current text is slightly inaccurate. Make it more correct. Change-Id: Iebe0051b74649d13982d7eefe3697f9e69c9b75d Reviewed-on: https://go-review.googlesource.com/c/go/+/340449 Trust: Russ Cox <rsc@golang.org> Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by: Jay Conrod <jayconrod@google.com> Reviewed-by: Damien Neil <dneil@google.com> Reviewed-by: Ian Lance Taylor <iant@golang.org> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-on: https://go-review.googlesource.com/c/go/+/341949 Trust: Dmitri Shuralyov <dmitshur@golang.org> Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Russ Cox <rsc@golang.org>
… helpers On Linux ARMv6 and below runtime/internal/atomic.Cas calls into a kernel cas helper at a fixed address. If a SIGPROF arrives while executing the kernel helper, the sigprof lostAtomic logic will miss that we are potentially in the spinlock critical section, which could cause a deadlock when using atomics later in sigprof. For #47505 Fixes #47688 Change-Id: If8ba0d0fc47e45d4e6c68eca98fac4c6ed4e43c1 Reviewed-on: https://go-review.googlesource.com/c/go/+/341889 Trust: Michael Pratt <mpratt@google.com> Run-TryBot: Michael Pratt <mpratt@google.com> Reviewed-by: Michael Knyszek <mknyszek@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com> TryBot-Result: Go Bot <gobot@golang.org> (cherry picked from commit 20a620f) Reviewed-on: https://go-review.googlesource.com/c/go/+/341890
…Swap The documentation for CompareAndSwap atomic/value incorrectly labelled the function as CompareAndSwapPointer. This PR fixes that. Updates #47699. Fixes #47703. Change-Id: I6db08fdfe166570b775248fd24550f5d28e3434e GitHub-Last-Rev: 41f78707928f48c9cdac26b6a4f618d4284e1ca1 GitHub-Pull-Request: golang/go#47700 Reviewed-on: https://go-review.googlesource.com/c/go/+/342210 Reviewed-by: Keith Randall <khr@golang.org> Reviewed-by: Daniel Martí <mvdan@mvdan.cc> Trust: Daniel Martí <mvdan@mvdan.cc> Run-TryBot: Daniel Martí <mvdan@mvdan.cc> TryBot-Result: Go Bot <gobot@golang.org> (cherry picked from commit 0a0a160) Reviewed-on: https://go-review.googlesource.com/c/go/+/342329 Trust: Dmitri Shuralyov <dmitshur@golang.org> Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
Change-Id: Ie59feb7f043574c7db4c7f14184603442638e4c0 Reviewed-on: https://go-review.googlesource.com/c/go/+/342470 Run-TryBot: Michael Knyszek <mknyszek@google.com> Trust: Michael Knyszek <mknyszek@google.com> Reviewed-by: Heschi Kreinick <heschi@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Go Bot <gobot@golang.org>
microsoft-golang-bot
requested review from
microsoft-golang-review-bot and
a team
as code owners
microsoft-golang-review-bot
approved these changes
Aug 19, 2021
microsoft-golang-review-bot
merged commit c54f4e5
into
microsoft:microsoft/release-branch.go1.17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔃 This is an automatically generated PR merging upstream
release-branch.go1.17intomicrosoft/release-branch.go1.17.This PR should auto-merge itself when PR validation passes. If CI fails and you need to make fixups, be sure to use a merge commit, not a squash or rebase!
After these changes, the difference between upstream and the branch is: