Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync 1.15 and 1.16 release branches from upstream #139

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Sync 1.15 and 1.16 release branches from upstream #139

merged 1 commit into from
Aug 23, 2021

Conversation

dagood
Copy link
Member

@dagood dagood commented Jul 16, 2021

@dagood dagood self-assigned this Jul 16, 2021
@dagood dagood marked this pull request as ready for review August 19, 2021 17:33
@dagood dagood requested a review from a team as a code owner August 19, 2021 17:33
@dagood
Copy link
Member Author

dagood commented Aug 19, 2021

@microsoft/golang-compiler PTAL. I pushed ahead on this one so we can have up-to-date Go builds to put in our Docker images. That way, we can more realistically ask people to try using them. (We were missing some 1.15.x/1.16.x fixes, and missing 1.17 altogether.)

@@ -41,5 +41,8 @@ jobs:
-to https://microsoft-golang-bot:$(BotAccount-microsoft-golang-bot-PAT)@github.com/microsoft-golang-bot/go `
-github-pat $(BotAccount-microsoft-golang-bot-PAT) `
-github-pat-reviewer $(BotAccount-microsoft-golang-review-bot-PAT) `
-b release-branch.go1.15 `
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to read this from, e.g. another yaml file or json or something?

Might be nice in the future to separate them out to so it's trivial to see which branches we're actively tracking.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, could have the tool take a branch list file, eng/merge-branches.json or so. Filed #191.

@dagood dagood merged commit 1e06f77 into microsoft:microsoft/main Aug 23, 2021
@dagood dagood deleted the sync-release branch August 23, 2021 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Go 1.17 release branch
3 participants