Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.15 infrastructure #135

Merged
merged 5 commits into from
Aug 6, 2021
Merged

Add 1.15 infrastructure #135

merged 5 commits into from
Aug 6, 2021

Conversation

dagood
Copy link
Member

@dagood dagood commented Jul 15, 2021

I used the same approach as with 1.16 (https://github.com/microsoft/go/tree/microsoft/main/eng/doc/branches#if-microsoftmain-didnt-exist-yet). Commits:

  1. Add infrastructure. Scripted process, just needed a couple obvious merge conflict fixes. No need to review.
  2. Apply the same moddeps_test fix from the 1.16 PR (Add 1.16 infrastructure #131).
  3. crypto/x509: Skip test that relies on expired cert: a patch to fix a Windows-only test break. Commit includes a code comment with details.
  4. Remove regabi builder: "unknown experiment regabi": this builder tried to run a Go experiment that isn't valid for this branch.
  5. Fix ssacheck builder: compile-only: fix a mismatch in how the builder is configured here vs. upstream. It's only meant to compile the tests, not run them.

Test official build: https://dev.azure.com/dnceng/internal/_build/results?buildId=1240387&view=results

dagood added 3 commits July 15, 2021 11:55
# Conflicts:
#	README.md
#	src/cmd/dist/test.go
# Conflicts:
#	src/cmd/internal/moddeps/moddeps_test.go
@dagood dagood self-assigned this Jul 15, 2021
@dagood
Copy link
Member Author

dagood commented Jul 15, 2021

/azp run microsoft-go-pr-outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dagood
Copy link
Member Author

dagood commented Jul 15, 2021

/azp run microsoft-go-pr-outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dagood
Copy link
Member Author

dagood commented Jul 16, 2021

@microsoft/golang-compiler PTAL, first commit is code flow (no need for review) and then a few fixups for CI. Similar to #131 (1.16).

The first commit has a few cherry-pick conflicts, but they were just README.md (took microsoft/main's because it has Microsoft content) and some adjacent line changes in the dist test -json patch.

Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 5)

@dagood dagood merged commit 8fc940f into microsoft:microsoft/release-branch.go1.15 Aug 6, 2021
@dagood dagood deleted the dev/dagood/1.15 branch August 6, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants