-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 1.15 infrastructure #135
Add 1.15 infrastructure #135
Conversation
# Conflicts: # README.md # src/cmd/dist/test.go
# Conflicts: # src/cmd/internal/moddeps/moddeps_test.go
/azp run microsoft-go-pr-outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run microsoft-go-pr-outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
@microsoft/golang-compiler PTAL, first commit is code flow (no need for review) and then a few fixups for CI. Similar to #131 (1.16). The first commit has a few cherry-pick conflicts, but they were just README.md (took |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks (iteration 5)
I used the same approach as with 1.16 (https://github.com/microsoft/go/tree/microsoft/main/eng/doc/branches#if-microsoftmain-didnt-exist-yet). Commits:
moddeps_test
fix from the 1.16 PR (Add 1.16 infrastructure #131).crypto/x509: Skip test that relies on expired cert
: a patch to fix a Windows-only test break. Commit includes a code comment with details.Remove regabi builder: "unknown experiment regabi"
: this builder tried to run a Go experiment that isn't valid for this branch.Fix ssacheck builder: compile-only
: fix a mismatch in how the builder is configured here vs. upstream. It's only meant to compile the tests, not run them.Test official build: https://dev.azure.com/dnceng/internal/_build/results?buildId=1240387&view=results