Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to review the first commit: it mechanically adds the Microsoft build infra by taking the diff of
microsoft/main
vs. upstreammaster
and applying it onrelease-branch.go1.16
. See https://github.com/microsoft/go/tree/microsoft/main/eng/doc/branches#if-microsoftmain-didnt-exist-yet for details.The other commits should be reviewed:
moddeps_test
because ofeng/_util
's external module dependencies: https://dev.azure.com/dnceng/internal/_build/results?buildId=1237987&view=results. This is an issue I've ran into before, and the_
prefix is meant to makemoddeps_test
skip the module._
/.
prefix is actually in upstreammaster
, but not in upstream 1.16. b0c49ae introduced the skip code (along with a lot of other changes!) sometime after the 1.16 release. I backported it and marked the lines asNO MICROSOFT_UPSTREAM
because upstream has no use for it without the rest of b0c49ae.Successful official build:
https://dev.azure.com/dnceng/internal/_build/results?buildId=1238036&view=results