Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.16 infrastructure #131

Merged
merged 2 commits into from
Aug 5, 2021
Merged

Add 1.16 infrastructure #131

merged 2 commits into from
Aug 5, 2021

Conversation

dagood
Copy link
Member

@dagood dagood commented Jul 14, 2021

No need to review the first commit: it mechanically adds the Microsoft build infra by taking the diff of microsoft/main vs. upstream master and applying it on release-branch.go1.16. See https://github.com/microsoft/go/tree/microsoft/main/eng/doc/branches#if-microsoftmain-didnt-exist-yet for details.

The other commits should be reviewed:

  • Second commit fixes CI: when I ran this branch, tests failed in moddeps_test because of eng/_util's external module dependencies: https://dev.azure.com/dnceng/internal/_build/results?buildId=1237987&view=results. This is an issue I've ran into before, and the _ prefix is meant to make moddeps_test skip the module.
    • The code that detects a _/. prefix is actually in upstream master, but not in upstream 1.16. b0c49ae introduced the skip code (along with a lot of other changes!) sometime after the 1.16 release. I backported it and marked the lines as NO MICROSOFT_UPSTREAM because upstream has no use for it without the rest of b0c49ae.

Successful official build:
https://dev.azure.com/dnceng/internal/_build/results?buildId=1238036&view=results

@dagood dagood self-assigned this Jul 14, 2021
@dagood dagood changed the title Dev/dagood/1.16 Add 1.16 infrastructure Jul 14, 2021
@dagood
Copy link
Member Author

dagood commented Jul 14, 2021

/azp run microsoft-go-pr-outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dagood dagood marked this pull request as ready for review July 15, 2021 14:43
@dagood dagood requested a review from a team July 15, 2021 14:52
@dagood dagood mentioned this pull request Jul 15, 2021
@dagood
Copy link
Member Author

dagood commented Jul 16, 2021

@microsoft/golang-compiler PTAL, first commit is code flow (generated via the flow in the PR description, no need for review) and second commit is a fixup for CI.

Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 2)

@dagood dagood merged commit 3bc440b into microsoft:microsoft/release-branch.go1.16 Aug 5, 2021
@dagood dagood deleted the dev/dagood/1.16 branch August 5, 2021 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants