-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add doc describing release branch strategy #147
Conversation
@jcouv can you take a look and make sure this makes sense vs. what we talked about walking through the 1.16/1.15 branches? @microsoft/golang-compiler PTAL, this should help give much better context for reviewing the release branch PRs: |
git rev-list golang/master..msft/microsoft/main | | ||
while read x; do | ||
if ! git merge-base --is-ancestor $release_base $x; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like there's got to be a way to do this with a rev-list
/log
expression rather than iterating and checking ourselves. I just can't quite find it. 😕
Makes eng/doc/branches easier to browse, especially if supplemental markdown files are added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks (iteration 3) with a nitpick to consider
Adds a doc that describes the process I went through to create the 1.15/1.16 PRs (#135, #131) and a better process we can use for future (1.17+) release branches.
Rendered: https://github.com/dagood/go/tree/describe-branches/eng/doc/branches