Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Source Link to Hermes PDB Files #102

Closed
dedavis6797 opened this issue May 31, 2022 · 0 comments · Fixed by #104
Closed

Add Source Link to Hermes PDB Files #102

dedavis6797 opened this issue May 31, 2022 · 0 comments · Fixed by #104
Assignees
@tudorms
Labels
enhancement New feature or request Status: Fixed

Comments

@dedavis6797
Copy link

Problem

Hermes crash dumps currently do not link to the repo's source code. This inhibits remote debugging experiences via processes like Watson.

Solution

Following the guidance at https://github.com/dotnet/designs/blob/main/accepted/2020/diagnostics/source-link.md#source-link-json-schema, we must create a sourcelink file and pass the /sourcelink:<file> compiler flag as described in https://docs.microsoft.com/en-us/cpp/build/reference/sourcelink?view=msvc-170 to our build script and/or cmake.

Additional Context

Example in msbuild syntax:

Write out the source file for this project to point at raw.githubusercontent.com
<WriteLinesToFile File="$(SourceLink)" Overwrite="true" Lines='{"documents": { "$(SourceLinkRoot)\\*" : "$(RemoteUri.Replace(".git", "").Replace("github.com", "raw.githubusercontent.com"))/$(LatestCommit)/*" }}' />

@dedavis6797 dedavis6797 added the enhancement New feature or request label May 31, 2022
tudorms added a commit to tudorms/hermes-windows that referenced this issue Jun 2, 2022
@tudorms
Add Source Link to linker. Addresses microsoft#102
0cbc3d5
@tudorms tudorms mentioned this issue Jun 2, 2022
Merged
tudorms added a commit that referenced this issue Jun 3, 2022
@tudorms
Fixes for 0.11 (#103)
7642a5d 
Disable Stats Timer (addresses #92)
Include revision as part of product version in addition to suffix (addresses #91)
Include license file in NuGet (addresses #98)
Add Source Link to linker (addresses #102)
@tudorms tudorms mentioned this issue Jun 4, 2022
Merged
@ghost ghost added the Status: In PR label Jun 4, 2022
@ghost ghost closed this as completed in #104 Jun 4, 2022
ghost pushed a commit that referenced this issue Jun 4, 2022
@tudorms
Bug fixes (#104)
06ac5ff 
- Disable Stats Timer (fixes #92)
- Include revision as part of product version in addition to suffix (fixes #91)
- Include license file in NuGet (fixes #98)
- Add Source Link to linker (fixes #102)

This is ported from the v0.11 branch. We bump the version up to 0.12 (even though no such version exists in upstream) to signal we're no longer compatible with 0.11 (and RN 0.68).
@ghost ghost added Status: Fixed and removed Status: In PR labels Jun 4, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jul 4, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tudorms tudorms

Labels
enhancement New feature or request Status: Fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bug fixes tudorms/hermes-windows
2 participants
@tudorms @dedavis6797