Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MIT Licensing Information to nuget Package #98

Closed
1 task
dedavis6797 opened this issue Apr 28, 2022 · 2 comments · Fixed by #104 or #107
Closed
1 task

Add MIT Licensing Information to nuget Package #98

dedavis6797 opened this issue Apr 28, 2022 · 2 comments · Fixed by #104 or #107
Assignees
@tudorms
Labels
bug Something isn't working Needs: triage 🔍 Status: Fixed

Comments

@dedavis6797
Copy link

Bug Description

Hermes currently does not include proper Licensing information which gets flagged by component governance in ADO.

  • I have run gradle clean and confirmed this bug does not occur with JSC

Hermes version: 0.11.2
@dedavis6797 dedavis6797 added the bug Something isn't working label Apr 28, 2022
@ghost ghost added the Needs: triage 🔍 label Apr 28, 2022
@tudorms
Copy link
Member

tudorms commented May 19, 2022

Need to replace $nugetroot$\license\*.* with $nugetroot$\license\* in the nuspec files.

@tudorms tudorms self-assigned this May 19, 2022
tudorms added a commit to tudorms/hermes-windows that referenced this issue Jun 2, 2022
@tudorms
Include license file in Nuget. Addresses microsoft#98
087dd1b
@tudorms tudorms mentioned this issue Jun 2, 2022
Merged
tudorms added a commit that referenced this issue Jun 3, 2022
@tudorms
Fixes for 0.11 (#103)
7642a5d 
Disable Stats Timer (addresses #92)
Include revision as part of product version in addition to suffix (addresses #91)
Include license file in NuGet (addresses #98)
Add Source Link to linker (addresses #102)
@tudorms tudorms mentioned this issue Jun 4, 2022
Merged
@ghost ghost added the Status: In PR label Jun 4, 2022
@ghost ghost closed this as completed in #104 Jun 4, 2022
ghost pushed a commit that referenced this issue Jun 4, 2022
@tudorms
Bug fixes (#104)
06ac5ff 
- Disable Stats Timer (fixes #92)
- Include revision as part of product version in addition to suffix (fixes #91)
- Include license file in NuGet (fixes #98)
- Add Source Link to linker (fixes #102)

This is ported from the v0.11 branch. We bump the version up to 0.12 (even though no such version exists in upstream) to signal we're no longer compatible with 0.11 (and RN 0.68).
@ghost ghost added Status: Fixed and removed Status: In PR labels Jun 4, 2022
@jonthysell jonthysell reopened this Jun 6, 2022
@jonthysell
Copy link

Adding license file to the package doesn't automatically register it as the package's license. Both the page on nuget.org (and Component Governance) still don't see that the package has an MIT license. See RNW's nuspec for an example of setting the right metadata.

tudorms added a commit to tudorms/hermes-windows that referenced this issue Jun 13, 2022
@tudorms
Include license metadata in NuGet (addresses microsoft#98)
729b325
@tudorms tudorms mentioned this issue Jun 13, 2022
Merged
@ghost ghost added Status: In PR and removed Status: Fixed labels Jun 13, 2022
@tudorms tudorms mentioned this issue Jun 13, 2022
Merged
@ghost ghost closed this as completed in #107 Jun 14, 2022
ghost pushed a commit that referenced this issue Jun 14, 2022
@tudorms
Include license metadata in NuGet (#107)
14dd642 
Include license metadata in NuGet (fixes #98)
ghost pushed a commit that referenced this issue Jun 14, 2022
@tudorms
[0.11] Include license metadata in NuGet (#108)
a938e5b 
Include license metadata in NuGet (fixes #98)
@ghost ghost added Status: Fixed and removed Status: In PR labels Jun 14, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jul 14, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tudorms tudorms

Labels
bug Something isn't working Needs: triage 🔍 Status: Fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bug fixes tudorms/hermes-windows
Include license metadata in NuGet tudorms/hermes-windows
3 participants
@jonthysell @tudorms @dedavis6797