fix: sets a version compatible with linux installations #5606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
captainsafia
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
I'm a little surprised that source-builds interact with the SDK version in global.json in this way. It makes me wonder how this was working before I made the change in #5535 since the version number that was previously used wasn't even a valid SDK number.
That being said this is still an improvement over that previous state and rollForward: latestMajor should do the right thing WRT to updating users so LGTM!
andrueastman
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related Homebrew/homebrew-core#193771
follow up to #5535
CC @captainsafia