Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kiota 1.19.1 #193771

Closed
wants to merge 1 commit into from
Closed

kiota 1.19.1 #193771

wants to merge 1 commit into from

Conversation

BrewTestBot
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

release notes
## Added

Changed

@github-actions github-actions bot added bump-formula-pr PR was created using `brew bump-formula-pr` dotnet .NET use is a significant feature of the PR or issue labels Oct 11, 2024
kiota: remove build patch

Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333
Copy link
Member

==> dotnet publish src/kiota/kiota.csproj --configuration Release --framework net8.0 --output /home/linuxbrew/.linuxbrew/Cellar/kiota/1.19.1/libexec --runtime linux-x64 --no-self-contained -p:TargetFramework=net8.0 -p:PublishSingleFile=true -p:Version=1.19.1
  The command could not be loaded, possibly because:
    * You intended to execute a .NET application:
        The application 'publish' does not exist.
    * You intended to execute a .NET SDK command:
        A compatible .NET SDK was not found.
  
  Requested SDK version: 8.0.402
  global.json file: /tmp/kiota-20241011-6275-9rpxlr/kiota-1.19.1/global.json
  
  Installed SDKs:
  
  Install the [8.0.402] .NET SDK or update [/tmp/kiota-20241011-[62](https://github.com/Homebrew/homebrew-core/actions/runs/11295566810/job/31418708174?pr=193771#step:4:63)75-9rpxlr/kiota-1.19.1/global.json] to match an installed SDK.
  
  Learn about SDK resolution:
  https://aka.ms/dotnet/sdk-not-found
  8.0.108 [/home/linuxbrew/.linuxbrew/Cellar/dotnet/8.0.8_1/libexec/sdk]

cc @baywet

@baywet
Copy link
Contributor

baywet commented Oct 11, 2024

@chenrui333 thanks for looping me in.
This is most likely caused by this change microsoft/kiota#5535 AND the fact that dotnet is behind on brew.
It could be addressed by:

  • fixing dotnet on brew so the newer version is available dotnet 8.0.10 #193272
  • adding a PR to kiota to downgrade the number to 8.0.108

@chenrui333
Copy link
Member

make sense, thanks!

@SMillerDev
Copy link
Member

fixing dotnet on brew so the newer version is available #193272

@baywet if you could help with that, it would be much appreciated.

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Oct 14, 2024
@baywet
Copy link
Contributor

baywet commented Oct 14, 2024

@SMillerDev while I work at Microsoft, I'm not on the dotnet team. And I have no additional knowledge with the problem this update is facing.
Nonetheless, I don't understand why this one is failing while requiring 8.0.402 when dotnet 8.0.8 IS 8.0.402 for the SDK
It's almost like the CI here is not using dotnet from homebrew, but a pre-installed version on the agent OS (which is behind)

==> brew fetch --formulae --retry berkeley-db@5 binutils bison bzip2 ca-certificates cmake dotnet elfutils expat gpatch icu4c@75 krb5 libedit libffi libnsl libtirpc libunwind libxcrypt llvm lttng-ust lz4 lzip m4 mpdecimal ncurses ninja numactl openssl@3 pcre2 pkg-config python@3.12 python@3.13 readline sqlite swig unzip userspace-rcu xz z3 zlib zstd
==> brew install --only-dependencies --verbose --formula --build-bottle kiota
==> brew install --formula gcc
==> SKIPPED kiota
Warning: dotnet cannot be built with any available compilers.
Install Clang or run `brew install gcc`.

This would support my theory, but I don't know enough about how homebrew's CI is supposed to work.

Does this help?

@github-actions github-actions bot removed the stale No recent activity label Oct 14, 2024
@iMichka
Copy link
Member

iMichka commented Oct 14, 2024

Checking the latest dotnet info from our package:

linuxbrew@581522043d57:~$ dotnet --version
8.0.108
linuxbrew@581522043d57:~$ dotnet sdk check

Welcome to .NET 8.0!
---------------------
SDK Version: 8.0.108

----------------
Installed an ASP.NET Core HTTPS development certificate.
To trust the certificate, view the instructions: https://aka.ms/dotnet-https-linux

----------------
Write your first app: https://aka.ms/dotnet-hello-world
Find out what's new: https://aka.ms/dotnet-whats-new
Explore documentation: https://aka.ms/dotnet-docs
Report issues and find source on GitHub: https://github.com/dotnet/core
Use 'dotnet --help' to see available commands or visit: https://aka.ms/dotnet-cli
--------------------------------------------------------------------------------------
.NET SDKs:
Version      Status
----------------------------------------
8.0.108      Patch 8.0.110 is available.

Try out the newest .NET SDK features with .NET 9.0.100-rc.2.24474.11.

.NET Runtimes:
Name                          Version      Status
---------------------------------------------------------------------
Microsoft.AspNetCore.App      8.0.8        Patch 8.0.10 is available.
Microsoft.NETCore.App         8.0.8        Patch 8.0.10 is available.


The latest versions of .NET can be installed from https://aka.ms/dotnet-core-download. For more information about .NET lifecycles, see https://aka.ms/dotnet-core-support.

So we do not provide this version of the SDK yet (8.0.402)

@baywet
Copy link
Contributor

baywet commented Oct 15, 2024

Thank you for the additional information.

I think I found why the version numbers differ between OSes

The Microsoft packages target later .NET SDK feature bands (like 6.0.4xx) while source-build tracks 6.0.1xx.

Since homebrew is building from the source, I believe this is why the version number doesn't match what's published on get.dot.net.

The only way to get around that I guess would be to lower the version number in the global.json for kiota. Let me stand a pull request up.

@@ -17,12 +17,6 @@ class Kiota < Formula

depends_on "dotnet"

Copy link
Contributor

@baywet baywet Oct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# compiler version mismatch patch, upstream pr ref, https://github.com/microsoft/kiota/pull/5606
patch do
url "https://github.com/microsoft/kiota/commit/fb91d056b08660452d8d30bd6dddfa4024e97594.patch?full_index=1"
sha256 "4188A55D5E125AF0BE275D2421A4A9886BF7BB7B8099AEE3F58A9853D166CD94"
end

@baywet
Copy link
Contributor

baywet commented Oct 16, 2024

@chenrui33 what do you think about my suggestion?

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Oct 19, 2024
@github-actions github-actions bot closed this Oct 20, 2024
@github-actions github-actions bot deleted the bump-kiota-1.19.1 branch October 20, 2024 04:08
@baywet baywet mentioned this pull request Oct 21, 2024
@baywet
Copy link
Contributor

baywet commented Oct 21, 2024

@chenrui33 @iMichka @SMillerDev I'm not sure why this got closed/the bot was a bit aggressive here. I opened #195061 to check if my fix works.

@chenrui333
Copy link
Member

@chenrui33 what do you think about my suggestion?

that would work.

@chenrui333 chenrui333 added the superseded PR was replaced by another PR label Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` dotnet .NET use is a significant feature of the PR or issue stale No recent activity superseded PR was replaced by another PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants