-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kiota 1.19.1 #193771
kiota 1.19.1 #193771
Conversation
kiota: remove build patch Signed-off-by: Rui Chen <rui@chenrui.dev>
1f0189d
to
15b9095
Compare
cc @baywet |
@chenrui333 thanks for looping me in.
|
make sense, thanks! |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a |
@SMillerDev while I work at Microsoft, I'm not on the dotnet team. And I have no additional knowledge with the problem this update is facing.
This would support my theory, but I don't know enough about how homebrew's CI is supposed to work. Does this help? |
Checking the latest dotnet info from our package:
So we do not provide this version of the SDK yet (8.0.402) |
Thank you for the additional information. I think I found why the version numbers differ between OSes
Since homebrew is building from the source, I believe this is why the version number doesn't match what's published on get.dot.net. The only way to get around that I guess would be to lower the version number in the global.json for kiota. Let me stand a pull request up. |
@@ -17,12 +17,6 @@ class Kiota < Formula | |||
|
|||
depends_on "dotnet" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# compiler version mismatch patch, upstream pr ref, https://github.com/microsoft/kiota/pull/5606 | |
patch do | |
url "https://github.com/microsoft/kiota/commit/fb91d056b08660452d8d30bd6dddfa4024e97594.patch?full_index=1" | |
sha256 "4188A55D5E125AF0BE275D2421A4A9886BF7BB7B8099AEE3F58A9853D166CD94" | |
end | |
@chenrui33 what do you think about my suggestion? |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a |
@chenrui33 @iMichka @SMillerDev I'm not sure why this got closed/the bot was a bit aggressive here. I opened #195061 to check if my fix works. |
that would work. |
Created by
brew bump
Created with
brew bump-formula-pr
.release notes