Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine rl component bundle #549

Merged
merged 20 commits into from
Dec 27, 2022
Merged

Refine rl component bundle #549

merged 20 commits into from
Dec 27, 2022

Conversation

lihuoran
Copy link
Contributor

Description

  • Refine rl_component_bundle. Use a more straightforward & easier way to organize. In this new version, we do not need easyrl anymore.
  • Update related examples.
  • Fix bugs in distributed training. Add config YAML file for distributed training in CIM scenario.
  • Add rl_formulation.ipynb as an example.

Linked issue(s)/Pull request(s)

Type of Change

  • Non-breaking bug fix
  • Breaking bug fix
  • New feature
  • Test
  • Doc update
  • Docker update

Related Component

  • Simulation toolkit
  • RL toolkit
  • Distributed toolkit

Has Been Tested

  • OS:
    • Windows
    • Mac OS
    • Linux
  • Python version:
    • 3.7
    • 3.8
    • 3.9
  • Key information snapshot(s):

Needs Follow Up Actions

  • New release package
  • New docker image

Checklist

  • Add/update the related comments
  • Add/update the related tests
  • Add/update the related documentations
  • Update the dependent downstream modules usage

@lihuoran lihuoran requested a review from Jinyu-W June 14, 2022 08:38
Jinyu-W
Jinyu-W previously approved these changes Dec 27, 2022
@codecov
Copy link

codecov bot commented Dec 27, 2022

Codecov Report

Merging #549 (1167fdc) into v0.3 (9fd91ff) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             v0.3     #549   +/-   ##
=======================================
  Coverage   79.30%   79.30%           
=======================================
  Files          86       86           
  Lines        5464     5464           
=======================================
  Hits         4333     4333           
  Misses       1131     1131           
Flag Coverage Δ
unittests 79.30% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
maro/simulator/abs_core.py 82.89% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Jinyu-W Jinyu-W merged commit 135d2fc into v0.3 Dec 27, 2022
@Jinyu-W Jinyu-W deleted the refine_rl_component_bundle branch December 27, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants