Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RL benchmark on GYM #575

Merged
merged 23 commits into from
Feb 6, 2023
Merged

RL benchmark on GYM #575

merged 23 commits into from
Feb 6, 2023

Conversation

lihuoran
Copy link
Contributor

Description

Linked issue(s)/Pull request(s)

Type of Change

  • Non-breaking bug fix
  • Breaking bug fix
  • New feature
  • Test
  • Doc update
  • Docker update

Related Component

  • Simulation toolkit
  • RL toolkit
  • Distributed toolkit

Has Been Tested

  • OS:
    • Windows
    • Mac OS
    • Linux
  • Python version:
    • 3.7
    • 3.8
    • 3.9
  • Key information snapshot(s):

Needs Follow Up Actions

  • New release package
  • New docker image

Checklist

  • Add/update the related comments
  • Add/update the related tests
  • Add/update the related documentations
  • Update the dependent downstream modules usage

@lihuoran lihuoran requested a review from Jinyu-W January 18, 2023 04:56
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #575 (b4db842) into v0.3 (eb6324c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             v0.3     #575   +/-   ##
=======================================
  Coverage   79.30%   79.30%           
=======================================
  Files          86       86           
  Lines        5464     5464           
=======================================
  Hits         4333     4333           
  Misses       1131     1131           
Flag Coverage Δ
unittests 79.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lihuoran lihuoran marked this pull request as ready for review January 28, 2023 03:11
tests/rl/algorithms/ac.py Outdated Show resolved Hide resolved
tests/rl/algorithms/ac.py Outdated Show resolved Hide resolved
tests/rl/algorithms/sac.py Outdated Show resolved Hide resolved
tests/rl/algorithms/sac.py Outdated Show resolved Hide resolved
tests/rl/gym_wrapper/config.py Show resolved Hide resolved
tests/rl/gym_wrapper/rl_component_bundle.py Outdated Show resolved Hide resolved
tests/rl/gym_wrapper/rl_component_bundle.py Show resolved Hide resolved
tests/rl/gym_wrapper/simulator/business_engine.py Outdated Show resolved Hide resolved
tests/rl/gym_wrapper/simulator/business_engine.py Outdated Show resolved Hide resolved
tests/rl/gym_wrapper/simulator/business_engine.py Outdated Show resolved Hide resolved
@Jinyu-W
Copy link
Collaborator

Jinyu-W commented Jan 30, 2023

How about add a md file under tests/rl to list the performance of these algorithms?

@Jinyu-W
Copy link
Collaborator

Jinyu-W commented Jan 30, 2023

How about add a md file under tests/rl to list the performance of these algorithms?

  • file added in PR 576, waiting for more details and experiment result
  • some comments resolved in PR 576 also

@Jinyu-W
Copy link
Collaborator

Jinyu-W commented Jan 30, 2023

PR 573 closed

Jinyu-W
Jinyu-W previously approved these changes Feb 6, 2023
@Jinyu-W Jinyu-W merged commit 214383f into v0.3 Feb 6, 2023
@Jinyu-W Jinyu-W deleted the rl_benchmark_debug branch February 6, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants